Skip to content

Commit ab2d1a5

Browse files
Some cleanup of TODO and REVIEW comments.
1 parent 36e262a commit ab2d1a5

File tree

5 files changed

+4
-8
lines changed

5 files changed

+4
-8
lines changed

clang/include/clang/3C/MultiDecls.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,6 @@ struct MultiDeclInfo {
153153
// Set by DeclRewriter::rewriteMultiDecl after it rewrites the entire
154154
// multi-decl to ensure that it doesn't try to do so more than once if
155155
// multiple members needed changes.
156-
// REVIEW: A design argument could be made that this flag doesn't belong here
157-
// and the rewriter should instead keep a visited set or something like that.
158156
bool AlreadyRewritten = false;
159157
};
160158

@@ -179,7 +177,7 @@ class ProgramMultiDeclsInfo {
179177
// Set of TagDecl names already used at least once in the program, so we can
180178
// avoid colliding with them.
181179
std::set<std::string> UsedTagNames;
182-
180+
183181
// Information about an originally unnamed tag definition in a multi-decl for
184182
// which we're using a new name.
185183
struct RenamedTagDefInfo {

clang/lib/3C/DeclRewriter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,10 +404,10 @@ void DeclRewriter::rewriteMultiDecl(MultiDeclInfo &MDI, RSet &ToRewrite) {
404404
// thinking that they can replace a different source range that way, we
405405
// want to fail fast.
406406
//
407-
// REVIEW: This is awkward and makes me wonder if we should just remove
407+
// This is awkward and makes me wonder if we should just remove
408408
// DeclReplacement::getSourceRange since 3C currently only calls
409409
// getSourceRange on an object already known to be a
410-
// FunctionDeclReplacement. But after drafting this, I wasn't convinced
410+
// FunctionDeclReplacement. But after drafting that, I wasn't convinced
411411
// that it was better than the status quo.
412412
assert(Replacement->getSourceRange(SM) == ReplaceSR);
413413
}

clang/lib/3C/MultiDecls.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "clang/3C/Utils.h"
1111

1212
MultiDeclMemberDecl *getAsMultiDeclMember(Decl *D) {
13-
// REVIEW: Is this the best place for this check?
13+
// XXX: Is this the best place for this check?
1414
if (D->getLocation().isInvalid())
1515
return nullptr;
1616

clang/test/3C/inline_anon_structs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ void foo2(int *x) {
182182

183183
// Tests of new functionality from
184184
// https://github.com/correctcomputation/checkedc-clang/pull/657.
185-
// TODO: Do we want to put this in a separate file?
186185

187186
// Test that 3C doesn't mangle the code by attempting to split a forward
188187
// declaration of a struct out of a multi-decl as if it were a definition

clang/test/3C/multivardecls.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ _Array_ptr<int> p1 : bounds((0, lo), hi), p2 : bounds(lo, (0, hi)), *p3;
267267
// https://github.com/correctcomputation/checkedc-clang/issues/651.
268268
// inline_anon_structs.c has a few additional tests of typedef multi-decls
269269
// involving inline structs.
270-
// TODO: Are there other cases we should test?
271270

272271
typedef int *A, *B;
273272
// CHECK: typedef _Ptr<int> A;

0 commit comments

Comments
 (0)