Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Identify whether segmentation is modified, and allow to reset status after user actions like Save or Undo etc #1780

Open
sen-trenser opened this issue Jan 24, 2025 · 0 comments

Comments

@sen-trenser
Copy link

What feature or change would you like to see made?

We would like to inquire whether Cornerstone3D provides a method for its consumers, such as the OHIF viewer, to determine whether a segmentation has been modified. If so, the consumer could perform specific actions or provide UI feedback, such as enabling or disabling a button or displaying a save confirmation dialog.

We have noticed a dirty flag is used here. However, it does not appear to be set appropriately because the segmentIndicesCache is not set. Should this flag be managed by Cornerstone3D itself?

  1. Will this flag be a part of the public API in Cornerstone3D 2.0?
  2. If not, what is the recommended approach for determining whether a segmentation has been modified?
  3. In our use case, we want to employ the isDirty flag to determine whether to enable the save button in the segmentations panel. We can employ the dirty flag, if available, to inspect the state of a segmentation to determine whether it has unsaved changes. Can you please advise how we can proceed with such an implementation?

Why should we prioritize this feature?

This feature would be a valuable addition to the product consumers.
It would provide better UX feedback on button state, and prompt users to save modified segmentations before navigating away from the viewer to prevent accidental data loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant