Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 incompatibility #16

Open
Vektor75 opened this issue Sep 6, 2018 · 0 comments
Open

PHP 7.2 incompatibility #16

Vektor75 opened this issue Sep 6, 2018 · 0 comments

Comments

@Vektor75
Copy link

Vektor75 commented Sep 6, 2018

I've installed on my dev laptop the PHP7.2 version, and it required to update yii2 to version 2.0.13 at least. And because of this workflow-manager has broken.

I suggest to create a branch for PHP7.2 compatibility with the following changes:

in the vendor\cornernote\yii2-workflow-manager\src\components\WorkflowDbSource.php file
change line 15
from this
use yii\base\Object;
to this
use yii\base\BaseObject;

and change line 35
from
class WorkflowDbSource extends Object implements IWorkflowSource
to the following
class WorkflowDbSource extends BaseObject implements IWorkflowSource

and that's it, after this small changes the extension is working without any errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant