Skip to content

Commit 955370e

Browse files
committed
fix(CSwitch): A component is changing an uncontrolled input of type checkbox to be controlled
- undefined `checked` prop causes a warning
1 parent 6be35c6 commit 955370e

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/CSwitch.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,14 @@ const CSwitch = props => {
5050
className={inputClasses}
5151
type="checkbox"
5252
onChange={change}
53-
checked={isChecked}
53+
checked={!!isChecked}
5454
{...attributes}
5555
ref={innerRef}
5656
/>
57-
<span
58-
className="c-switch-slider"
59-
data-checked={labelOn}
60-
data-unchecked={labelOff}
61-
></span>
57+
<span className="c-switch-slider"
58+
data-checked={labelOn}
59+
data-unchecked={labelOff}
60+
/>
6261
</label>
6362
)
6463
}

0 commit comments

Comments
 (0)