Skip to content

Commit 0c40851

Browse files
committed
Merge branch 'Tubek-fix/ios-safari-9-sidebar-toggle-fix'
2 parents 6b44f19 + 2217609 commit 0c40851

File tree

4 files changed

+43
-9
lines changed

4 files changed

+43
-9
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
### [@coreui/react](https://coreui.io/) changelog
22

3+
##### `v2.1.5`
4+
- fix: iOS 9 Safari sidebar toggle force issue #61 - thanks @Tubek
5+
- refactor(toggle-classes): keep `force` for the toggle method
6+
- refactor(layout): drop second parameter for `classList.toggle()`
7+
8+
###### dependencies update
9+
- update `enzyme-adapter-react-16` to `^1.10.0`
10+
- update `eslint` to `^5.15.1`
11+
- update `react` to `^16.8.3`
12+
- update `react-dom` to `^16.8.3`
13+
314
##### `v2.1.4`
415
- fix(Sidebar): *How to set left sidebar is minimized as default* [#145](https://github.com/coreui/coreui-free-react-admin-template/issues/145)
516
- refactor(Layout): `LayoutHelper` germ

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/react",
3-
"version": "2.1.4",
3+
"version": "2.1.5",
44
"description": "CoreUI React Bootstrap 4 components",
55
"license": "MIT",
66
"author": {
@@ -51,13 +51,13 @@
5151
"devDependencies": {
5252
"babel-eslint": "^10.0.1",
5353
"enzyme": "^3.9.0",
54-
"enzyme-adapter-react-16": "^1.9.1",
55-
"eslint": "^5.14.1",
54+
"enzyme-adapter-react-16": "^1.10.0",
55+
"eslint": "^5.15.1",
5656
"eslint-plugin-import": "^2.16.0",
5757
"eslint-plugin-react": "^7.12.4",
5858
"nwb": "^0.23.0",
59-
"react": "^16.8.2",
60-
"react-dom": "^16.8.2",
59+
"react": "^16.8.3",
60+
"react-dom": "^16.8.3",
6161
"sinon": "^5.1.1"
6262
},
6363
"repository": {

src/Shared/layout/layout.js

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,22 @@
11
class LayoutHelper {
22

3+
static elClassList = document.body.classList;
4+
35
static sidebarToggle(toggle) {
4-
const minimize = arguments.length ? toggle : !document.body.classList.contains('sidebar-minimized');
6+
const minimize = arguments.length ? toggle : !this.elClassList.contains('sidebar-minimized');
57
this.sidebarMinimize(minimize);
68
this.brandMinimize(minimize);
79
this.sidebarPSToggle(!minimize); /*remove PS on sidebar minimized*/
810
}
911

1012
static sidebarMinimize(force) {
11-
return document.body.classList.toggle('sidebar-minimized', force);
13+
// return this.elClassList.toggle('sidebar-minimized', force);
14+
return this.toggleClass('sidebar-minimized', force);
1215
}
1316

1417
static brandMinimize(force) {
15-
document.body.classList.toggle('brand-minimized', force);
18+
// this.elClassList.toggle('brand-minimized', force);
19+
this.toggleClass('brand-minimized', force);
1620
}
1721

1822
// sidebar perfect scrollbar
@@ -26,6 +30,18 @@ class LayoutHelper {
2630
}
2731
}
2832
}
33+
34+
static toggleClass(className, force) {
35+
36+
if (force === true) {
37+
this.elClassList.add(className);
38+
} else if (force === false) {
39+
this.elClassList.remove(className);
40+
} else {
41+
this.elClassList.toggle(className);
42+
}
43+
return this.elClassList.contains(className);
44+
}
2945
}
3046

3147
export default LayoutHelper;

src/Shared/toggle-classes.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,12 @@ export default function toggleClasses (toggleClass, classList, force) {
22
const level = classList.indexOf(toggleClass)
33
const removeClassList = classList.slice(0, level)
44
removeClassList.map((className) => document.body.classList.remove(className))
5-
document.body.classList.toggle(toggleClass, force)
5+
if (force === true) {
6+
document.body.classList.add(toggleClass);
7+
} else if (force === false) {
8+
document.body.classList.remove(toggleClass);
9+
} else {
10+
document.body.classList.toggle(toggleClass);
11+
}
12+
return document.body.classList.contains(toggleClass);
613
}

0 commit comments

Comments
 (0)