From a40d380a1ba89e0706d437962774998307df75a9 Mon Sep 17 00:00:00 2001 From: Max Leske <250711+theseion@users.noreply.github.com> Date: Fri, 3 Jan 2025 15:15:19 +0100 Subject: [PATCH] fix: tolerate tests that do not specify any headers (#438) Fixes #437 --- ftwhttp/header.go | 5 +---- ftwhttp/request_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/ftwhttp/header.go b/ftwhttp/header.go index daa3d59a..af3cd3cb 100644 --- a/ftwhttp/header.go +++ b/ftwhttp/header.go @@ -111,11 +111,8 @@ func (h Header) WriteBytes(b *bytes.Buffer) (int, error) { return count, nil } -// Clone returns a copy of h or nil if h is nil. +// Clone returns a copy of h func (h Header) Clone() Header { - if h == nil { - return nil - } clone := make(Header) for n, v := range h { diff --git a/ftwhttp/request_test.go b/ftwhttp/request_test.go index 2d97bd7c..18050e43 100644 --- a/ftwhttp/request_test.go +++ b/ftwhttp/request_test.go @@ -289,3 +289,17 @@ func (s *requestTestSuite) TestRequestEncodesPostData() { }) } } + +func (s *requestTestSuite) TestNewRequest_EmptyHeaders() { + rl := &RequestLine{ + Method: "POST", + URI: "/path", + Version: "1.1", + } + + req := NewRequest(rl, nil, []byte{}, false) + + headers := req.Headers() + s.NotNil(headers) + s.Empty(headers) +}