Skip to content

Commit 819e3ce

Browse files
committed
Add log-level param for buildextend subcommands
When log-level is set for buildextend command it would be passed to `ore`. This would help with getting more info when upload fails
1 parent 9c0558f commit 819e3ce

4 files changed

+43
-25
lines changed

src/cmd-aws-replicate

+5-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ parser.add_argument("--build", help="Build ID",
2828
parser.add_argument("--name-suffix", help="Suffix for name")
2929
parser.add_argument("--regions", help="EC2 regions",
3030
default=default_all_regions, nargs='+')
31+
parser.add_argument("--log-level", help="ore log level")
3132
args = parser.parse_args()
3233

3334
builds = Builds()
@@ -57,8 +58,10 @@ def run_ore():
5758

5859
source_image = buildmeta['amis'][0]['hvm']
5960
source_region = buildmeta['amis'][0]['name']
60-
ore_args = ['ore', 'aws', 'copy-image',
61-
'--image', source_image, '--region', source_region]
61+
ore_args = ['ore']
62+
if args.log_level:
63+
ore_args.extend(['--log-level', args.log_level])
64+
ore_args.extend(['aws', 'copy-image', '--image', source_image, '--region', source_region])
6265
ore_args.extend(region_list)
6366
print("+ {}".format(subprocess.list2cmdline(ore_args)))
6467
ore_data = json.loads(subprocess.check_output(ore_args))

src/cmd-buildextend-aws

+14-10
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ parser.add_argument("--bucket", help="S3 Bucket",
2222
parser.add_argument("--name-suffix", help="Suffix for name")
2323
parser.add_argument("--grant-user", help="Grant user launch permission",
2424
nargs="*", default=[])
25+
parser.add_argument("--log-level", help="ore log level")
2526
args = parser.parse_args()
2627

2728
builds = Builds()
@@ -57,16 +58,19 @@ def generate_aws_vmdk():
5758

5859
def run_ore():
5960
tmp_img_aws_vmdk = generate_aws_vmdk()
60-
ore_args = ['ore', 'aws', 'upload',
61-
'--region', args.region,
62-
'--bucket', args.bucket,
63-
'--ami-name', ami_name_version,
64-
'--name', ami_name_version,
65-
'--ami-description', f"{buildmeta['summary']} {args.build}",
66-
'--file', tmp_img_aws_vmdk,
67-
'--disk-size-inspect',
68-
'--delete-object',
69-
'--force']
61+
ore_args = ['ore']
62+
if args.log_level:
63+
ore_args.extend(['--log-level', args.log_level])
64+
ore_args.extend(['aws', 'upload',
65+
'--region', args.region,
66+
'--bucket', args.bucket,
67+
'--ami-name', ami_name_version,
68+
'--name', ami_name_version,
69+
'--ami-description', f"{buildmeta['summary']} {args.build}",
70+
'--file', tmp_img_aws_vmdk,
71+
'--disk-size-inspect',
72+
'--delete-object',
73+
'--force'])
7074
for user in args.grant_user:
7175
ore_args.extend(['--grant-user', user])
7276
print("+ {}".format(subprocess.list2cmdline(ore_args)))

src/cmd-buildextend-azure

+6-2
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ def cli():
124124
parser.add_argument(
125125
'--storage-account', help='Storage account', required=True,
126126
default=os.environ.get('AZURE_STORAGE_ACCOUNT'))
127+
parser.add_argument("--log-level", help="ore log level")
127128
args = parser.parse_args()
128129

129130
# Argument checks for environment strings that are required
@@ -166,8 +167,11 @@ def run_ore(args, build):
166167
:type build: Build
167168
"""
168169
azure_vhd_path = os.path.join(build.build_dir, build.azure_vhd_name)
169-
ore_upload_args = [
170-
'ore', 'azure', 'upload-blob-arm',
170+
ore_upload_args = ['ore']
171+
if args.log_level:
172+
ore_upload_args.extend(['--log-level', args.log_level])
173+
ore_upload_args.extend([
174+
'azure', 'upload-blob-arm',
171175
'--azure-auth', args.auth,
172176
'--azure-location', args.location,
173177
'--azure-profile', args.profile,

src/cmd-buildextend-gcp

+18-11
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ parser.add_argument("--name-suffix", help="Append suffix to name",
3636
required=False)
3737
parser.add_argument("--project", help="GCP Project name",
3838
default=os.environ.get("GCP_PROJECT_NAME"))
39+
parser.add_argument("--log-level", help="ore log level")
3940
args = parser.parse_args()
4041

4142
# Argument checks for environment strings that are required
@@ -95,17 +96,23 @@ def run_ore():
9596
""" Execute ore to upload the tarball and register the image """
9697
build_tarball = f"{builddir}/{gcp_tarball_name}"
9798
tmp_img_gcp_tarball = generate_gcp_tar()
98-
ore_args = ['ore', 'gcloud',
99-
'--project', args.project,
100-
'--basename', base_name,
101-
'upload',
102-
'--force', # We want to support restarting the pipeline
103-
'--board=""',
104-
'--bucket', f'gs://{args.bucket}/{base_name}',
105-
'--json-key', args.json_key,
106-
'--name', f'{args.build}',
107-
'--file', tmp_img_gcp_tarball
108-
]
99+
ore_args = ['ore']
100+
if args.log_level:
101+
ore_args.extend(['--log-level', args.log_level])
102+
ore_args.extend([
103+
'gcloud',
104+
'--project', args.project,
105+
'--basename', base_name,
106+
'upload',
107+
'--force', # We want to support restarting the pipeline
108+
'--board=""',
109+
'--bucket', f'gs://{args.bucket}/{base_name}',
110+
'--json-key', args.json_key,
111+
'--name', f'{args.build}',
112+
'--file', tmp_img_gcp_tarball
113+
])
114+
if args.log_level:
115+
ore_args.extend(['--log-level', args.log_level])
109116

110117
run_verbose(ore_args)
111118
os.rename(tmp_img_gcp_tarball, build_tarball)

0 commit comments

Comments
 (0)