Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create accounts #216

Open
markjd84 opened this issue Apr 21, 2015 · 3 comments
Open

Cannot create accounts #216

markjd84 opened this issue Apr 21, 2015 · 3 comments

Comments

@markjd84
Copy link

Under "Account Management > Create Account" it is impossible to select a new username that is accepted as valid. Looking at the code in Admin.checkUsername() I suspect the responses are the wrong way round: it currently says

 if (!exists)
    badRequest();

but I suspect it should be if(exists). For example, any random string fhghf is reported as already taken.

@JWJoubert
Copy link

I don't think I have commit rights, and have not seen any updates on this issue. I have the same problem, and it is becoming quite urgent/critical for me. Is there a chance, Mark, that you can make the change and commit please? Or is there a specific workflow. If so, and you let me know, I'll try and get the ball rolling on my side and get this done.

Thanks!
Johan

@JWJoubert
Copy link

I've been able to fix this locally, and it seems to work. With permission I can commit the (really minor) change - I just don't know if there might be, given the overall design, unintended consequences.

@markjd84
Copy link
Author

Sorry, I don't have commit rights either - I've been using a local change! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants