Merge pull request #3725 from apostasie/fs-tests

validatePathComponent tests

Author: djdongjin

pkg/store/filestore_test.go

@@ -17,6 +17,8 @@
 package store
 
 import (
+	"fmt"
+	"runtime"
 	"testing"
 	"time"
 
@@ -218,3 +220,60 @@ func TestFileStoreConcurrent(t *testing.T) {
 	})
 	assert.NilError(t, lErr, "locking should not error")
 }
+
+func TestFileStoreFilesystemRestrictions(t *testing.T) {
+	invalid := []string{
+		"/",
+		"/start",
+		"mid/dle",
+		"end/",
+		".",
+		"..",
+		"",
+		fmt.Sprintf("A%0255s", "A"),
+	}
+
+	valid := []string{
+		fmt.Sprintf("A%0254s", "A"),
+		"test",
+		"test-hyphen",
+		".start.dot",
+		"mid.dot",
+		"∞",
+	}
+
+	if runtime.GOOS == "windows" {
+		invalid = append(invalid, []string{
+			"\\start",
+			"mid\\dle",
+			"end\\",
+			"\\",
+			"\\.",
+			"com².whatever",
+			"lpT2",
+			"Prn.",
+			"nUl",
+			"AUX",
+			"A<A",
+			"A>A",
+			"A:A",
+			"A\"A",
+			"A|A",
+			"A?A",
+			"A*A",
+			"end.dot.",
+			"end.space ",
+		}...)
+	}
+
+	for _, v := range invalid {
+		err := validatePathComponent(v)
+		assert.ErrorIs(t, err, ErrInvalidArgument, v)
+	}
+
+	for _, v := range valid {
+		err := validatePathComponent(v)
+		assert.NilError(t, err, v)
+	}
+
+}

pkg/store/filestore_windows.go

@@ -38,7 +38,7 @@ func validatePlatformSpecific(pathComponent string) error {
 	}
 
 	if pathComponent[len(pathComponent)-1:] == "." || pathComponent[len(pathComponent)-1:] == " " {
-		return fmt.Errorf("identifier %q cannot end with a space of dot", pathComponent)
+		return fmt.Errorf("identifier %q cannot end with a space or dot", pathComponent)
 	}
 
 	return nil