fix teacher share cypress test

- the teacher was added to a group (teachers aren't supposed to be in groups
- the sort group sections weren't loaded before being expanded

Author: scytacki

cypress.config.ts

@@ -28,7 +28,7 @@ export default defineConfig({
   qaUnitTeacher6Network: "/?appMode=qa&fakeClass=5&fakeUser=teacher:6&problem=1.1&unit=./demo/units/qa/content.json&network=foo",
   qaNoGroupShareUnitStudent5: "/?appMode=qa&fakeClass=5&fakeUser=student:5&qaGroup=5&problem=1.1&unit=./demo/units/qa-no-group-share/content.json",
   qaConfigSubtabsUnitStudent5: "/?appMode=qa&fakeClass=5&fakeUser=student:5&qaGroup=5&problem=1.1&unit=./demo/units/qa-config-subtabs/content.json",
-  qaConfigSubtabsUnitTeacher1: "/?appMode=qa&fakeClass=5&fakeUser=teacher:1&qaGroup=5&problem=1.1&unit=./demo/units/qa-config-subtabs/content.json",
+  qaConfigSubtabsUnitTeacher1: "/?appMode=qa&fakeClass=5&fakeUser=teacher:1&problem=1.1&unit=./demo/units/qa-config-subtabs/content.json",
   qaNoNavPanelUnitStudent5: "/?appMode=qa&fakeClass=5&fakeUser=student:5&qaGroup=5&problem=1.1&unit=./demo/units/qa-no-nav-panel/content.json",
   qaVariablesUnitStudent5: "/?appMode=qa&fakeClass=5&fakeUser=student:5&qaGroup=5&problem=1.1&unit=./demo/units/qa-variables/content.json",
   qaShowNavPanelUnitStudent5: "/?appMode=qa&fakeClass=5&fakeUser=student:5&qaGroup=5&problem=1.1&unit=./demo/units/qa-show-nav-panel/content.json",

cypress/e2e/functional/teacher_tests/teacher_share_spec.js

@@ -19,15 +19,22 @@ function verifySwitch(publicOrPrivate) {
   clueCanvas.getShareButton().should('have.class', publicOrPrivate);
 }
 
+function verifySectionsAreLoaded() {
+  cy.get('.section-header-label').should("contain", "Group 5");
+  cy.get('.section-header-label').should("contain", "No Group");
+}
+
 function verifyStudentSeesAsPrivate() {
   cy.get('.tab-sort-work').click();
+  verifySectionsAreLoaded();
   cy.get('.section-header-arrow').click({multiple: true});
   cy.contains('[data-test="sort-work-list-items"]','Teacher 1:')
     .should('have.descendants', '.thumbnail-private');
 }
 
 function verifyStudentSeesAsPublic() {
   cy.get('.tab-sort-work').click();
+  verifySectionsAreLoaded();
   cy.get('.section-header-arrow').click({multiple: true});
   cy.contains('[data-test="sort-work-list-items"]','Teacher 1:')
     .should('not.have.descendants', '.thumbnail-private');

src/components/app.tsx

@@ -22,7 +22,7 @@ function resolveAppMode(
   stores: IStores,
   rawFirebaseJWT: string | undefined
 ) {
-  const { appMode, db, ui} = stores;
+  const { appMode, db, ui, user} = stores;
   if (appMode === "authed")  {
     if (rawFirebaseJWT) {
       return db.connect({appMode, stores, rawFirebaseJWT}).catch(error => ui.setError(error));
@@ -34,7 +34,8 @@ function resolveAppMode(
   else {
     return db.connect({appMode, stores})
       .then(() => {
-        if (appMode === "qa") {
+        // Only students can be part of groups
+        if (appMode === "qa" && user.isStudent) {
           const {qaGroup} = urlParams;
           if (qaGroup) {
             db.leaveGroup().then(() => db.joinGroup(qaGroup));