PHPStan fixes

Author: Seldaek

phpstan.neon

@@ -7,6 +7,7 @@ includes:
     - vendor/phpstan/phpstan-symfony/extension.neon
     - vendor/phpstan/phpstan-symfony/rules.neon
     - vendor/phpstan/phpstan-webmozart-assert/extension.neon
+    - vendor/composer/pcre/extension.neon
     - vendor/staabm/phpstan-dba/config/dba.neon
     - vendor/staabm/phpstan-todo-by/extension.neon
     - vendor/phpstan/phpstan-deprecation-rules/rules.neon

src/Controller/ApiController.php

@@ -553,8 +553,6 @@ protected function findPackagesByUrl(User $user, string $url, string $urlRegex,
                 $url === 'https://packagist.org/packages/'.$package->getName()
                 || (
                     Preg::isMatch($urlRegex, $package->getRepository(), $candidate)
-                    && isset($candidate['host'], $candidate['path'])
-                    && isset($matched['host'], $matched['path'])
                     && strtolower($candidate['host']) === strtolower($matched['host'])
                     && strtolower($candidate['path']) === strtolower($matched['path'])
                 )

src/Entity/PhpStatRepository.php

@@ -281,8 +281,6 @@ private function getKeyInfo(Package $package, string $key): array
             throw new \LogicException('Expected keys for package id '.$package->getId().', got '.$key);
         }
 
-        assert(isset($match['package'], $match['version'], $match['phpversion'], $match['date']));
-
         return [
             'type' => $match['platform'] === 'platform' ? PhpStat::TYPE_PLATFORM : PhpStat::TYPE_PHP,
             'version' => $match['version'],

src/Entity/User.php

@@ -363,6 +363,10 @@ public function getId(): int
 
     public function getUserIdentifier(): string
     {
+        if ($this->usernameCanonical === '') {
+            throw new \LogicException('usernameCanonical cannot be empty string');
+        }
+
         return $this->usernameCanonical;
     }
 

src/Package/SymlinkDumper.php

@@ -81,8 +81,6 @@ public function __construct(
          * @var int 0 disabled, 9 maximum.
          */
         private int $compress,
-        /** @var AwsMetadata */
-        private array $awsMetadata,
         private StatsDClient $statsd,
         private Logger $logger,
     ) {

src/Package/V2Dumper.php

@@ -45,8 +45,6 @@ public function __construct(
         private Client $redis,
         private string $webDir,
         private string $buildDir,
-        /** @var AwsMetadata */
-        private array $awsMetadata,
         private StatsDClient $statsd,
         private ProviderManager $providerManager,
         private Logger $logger,

src/Util/UserAgentParser.php

@@ -26,7 +26,6 @@ class UserAgentParser
     public function __construct(?string $userAgent)
     {
         if ($userAgent && Preg::isMatch('#^Composer/(?P<composer>[a-z0-9.+-]+) \((?P<os>[^\s;]+)[^;]*?; (?P<osversion>[^;]*?); (?P<engine>HHVM|PHP) (?P<php>[0-9.]+)[^;]*(?:; (?P<http>streams|curl \d+\.\d+)[^;)]*)?(?:; Platform-PHP (?P<platform_php>[0-9.]+)[^;]*)?(?P<ci>; CI)?#i', $userAgent, $matches)) {
-            assert(isset($matches['composer'], $matches['engine'], $matches['os'], $matches['php']));
             if ($matches['composer'] === 'source' || Preg::isMatch('{^[a-f0-9]{40}$}', $matches['composer'])) {
                 $matches['composer'] = 'pre-1.8.5';
             }