Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

component-install randomly downloads corrupt files #617

Closed
sankargorthi opened this issue Dec 15, 2014 · 8 comments
Closed

component-install randomly downloads corrupt files #617

sankargorthi opened this issue Dec 15, 2014 · 8 comments

Comments

@sankargorthi
Copy link
Member

We're on component(1)@0.19.9

Our CI tool always deletes the components folder and does a component install each time. We've started observing today that the downloaded files seem to randomly contain truncated sections (in the middle of the file) and our builds fail.

Is it something others have observed?

@sankargorthi
Copy link
Member Author

Also, all our errors currently seem to be in our lodash/lodash: "2.4.1" dependency. Not sure if this is useful or relevant.

@dominicbarnes
Copy link
Contributor

component@0 gets less reliable as your dependency tree grows. Since it only includes 1 folder for each dependency, when it comes to conflicting versions it will behave inconsistently. Sometimes, 1 version clearly wins, sometimes you get a corrupted file.

The point is, you should really consider upgrading to component@1, it fixes this particular issue and lots lots more, while retaining backwards-compatibility. (for the most part, I'm sure there will be edge-cases)

@sankargorthi
Copy link
Member Author

We're unfortunately limited to 0.19.9 as I was unable to figure out how to point component to a custom remote repo on our VPN (gitlab). Is there some documentation or examples on how to do this with component@1?

We're using component-bundle to drive our builds and we only do component-install once. We're manually managing our dependencies and they're all on the same version or on '*'. I'm pretty sure we don't have conflicts.

@dominicbarnes
Copy link
Contributor

Oh bummer, that does complicate things. One option, albeit not a very pretty one, is to add a working components directory to your git repo, I had to resort to that when we were stuck with 0.19.x.

@netpoetica
Copy link

@sankargorthi I have intentions to make Gitlab a possibility for component, but unfortunately I am not super-familiar with Gitlab.

You may want to look at component remotes and see what I did to make BitBucket a possibility. It shouldn't be much more work than what was done for BitBucket to be able to make Gitlab a reality for component@1.

I would definitely be willing to work with you to bring this to component if you're interested

@sankargorthi
Copy link
Member Author

@netpoetica absolutely! anything to get us up to the latest version of component(1). I'll move this over to remotes then.

@netpoetica
Copy link

@timaschew are we still fixing bugs in lower versions of component at this point? Aside from the idea of adding the remote which is awesome, this is still a strange bug. I would like to keep away from < 0, what do you think?

@timaschew
Copy link
Member

Yep, I think supporting < 0 isn't worth it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants