Skip to content

Commit 5efd778

Browse files
committed
rename .name to .basename
1 parent 67133b5 commit 5efd778

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

lib/builder.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function Builder(dir, parent) {
3939
this.dir = dir;
4040
this.root = ! parent;
4141
this.parent = parent;
42-
this.name = basename(dir);
42+
this.basename = basename(dir);
4343
this.paths = ['components'];
4444
this.ignored = {
4545
scripts: [],
@@ -197,7 +197,7 @@ Builder.prototype.lookup = function(name, fn){
197197
var path = paths[i++];
198198

199199
// no more paths
200-
if (!path) return fn(new Error('failed to lookup "' + self.name + '"\'s dependency "' + name + '"'));
200+
if (!path) return fn(new Error('failed to lookup "' + self.basename + '"\'s dependency "' + name + '"'));
201201

202202
// path
203203
var dir = join(path, name);
@@ -452,18 +452,18 @@ Builder.prototype.buildAliases = function(fn){
452452
// TODO: remove special-casing root
453453
var alias = self.root
454454
? self.conf.name + '/deps/' + name + '/' + script
455-
: self.name + '/deps/' + name + '/' + script;
455+
: self.basename + '/deps/' + name + '/' + script;
456456

457-
var js = 'require.alias("' + builder.name + '/' + script + '", "' + alias + '");\n';
457+
var js = 'require.alias("' + builder.basename + '/' + script + '", "' + alias + '");\n';
458458
return js;
459459
});
460460

461461
if (main) {
462462
var alias = self.root
463463
? self.conf.name + '/deps/' + name + '/index.js'
464-
: self.name + '/deps/' + name + '/index.js';
464+
: self.basename + '/deps/' + name + '/index.js';
465465

466-
aliases.push('require.alias("' + builder.name + '/' + main + '", "' + alias + '");\n');
466+
aliases.push('require.alias("' + builder.basename + '/' + main + '", "' + alias + '");\n');
467467
}
468468

469469
aliases = aliases.join('');
@@ -483,7 +483,7 @@ Builder.prototype.buildAliases = function(fn){
483483
var conf = self.conf;
484484
var name = self.root
485485
? conf.name
486-
: self.name;
486+
: self.basename;
487487

488488
if (conf.main) {
489489
res.push('require.alias("' + name + '/' + conf.main + '", "' + name + '/index.js");\n');
@@ -505,7 +505,7 @@ Builder.prototype.buildAliases = function(fn){
505505

506506
Builder.prototype.buildType = function(type, fn, process){
507507
var self = this;
508-
debug('building %s %s', this.name, type);
508+
debug('building %s %s', this.basename, type);
509509

510510
this.json(function(err, conf){
511511
if (err) return fn(err);
@@ -613,7 +613,7 @@ Builder.prototype.buildAsset = function(type, fn){
613613
if (conf[type]) {
614614
conf[type].forEach(function(file){
615615
var path = self.path(file);
616-
var name = normalize(self.name);
616+
var name = normalize(self.basename);
617617
var dest = join(self.assetsDest, name, file);
618618
batch.push(function(done){
619619
self.copyTo(path, dest, done);
@@ -793,7 +793,7 @@ function noop(builder, file, str){
793793
function register(builder, file, js){
794794
file = builder.root
795795
? builder.conf.name + '/' + file
796-
: builder.name + '/' + file;
796+
: builder.basename + '/' + file;
797797

798798
if (builder.sourceUrls) {
799799
return 'require.register("' + file + '", Function("exports, require, module",\n'
@@ -834,7 +834,7 @@ function rewriteUrls(builder, file, css) {
834834
url = utils.stripQuotes(url);
835835
if (isData(url)) return orig;
836836
if (isAbsolute(url)) return orig;
837-
var name = normalize(builder.name);
837+
var name = normalize(builder.basename);
838838
url = join(builder.urlPrefix, '/', name, dirname(file), url);
839839
return 'url("' + url + '")';
840840
}

test/builder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('Builder', function(){
4343
builder.buildScripts(function(){});
4444
builder.on('dependency', function(builder){
4545
builder.dir.should.be.a('string');
46-
builder.name.should.equal('component-emitter');
46+
builder.basename.should.equal('component-emitter');
4747
done();
4848
});
4949
})
@@ -67,7 +67,7 @@ describe('Builder', function(){
6767
builder.buildStyles(function(){});
6868
builder.on('dependency', function(builder){
6969
builder.dir.should.be.a('string');
70-
builder.name.should.equal('component-emitter');
70+
builder.basename.should.equal('component-emitter');
7171
done();
7272
});
7373
})

0 commit comments

Comments
 (0)