Fixes to get main working downstream again (#841)

* Update base swift compiler to 20231016.5

The 20231016.5 is a new build based on 20231016.0
that has the fix for `static_assert(false` failure
in Clang that was failing to compile Swift with updated
MSVC c++ headers.

* GHA workflow: add swift testing package name

The build of swift testing now requires a specified package name,
as swift testing uses the 'package' keyword. swift_testing the
name used in the cmake build as well.

* Do not attempt NuGet registration

This is now failing as NuGet is registered:

```
Register-PackageSource: D:\r\_work\_temp\c04a7ca5-aa41-491b-b9ad-0e09fb799d0c.ps1:4
Line |
   4 |      Register-PackageSource -Name NuGet -Location https://www.nuget.or …
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Package Source 'NuGet' exists.
```

https://github.com/thebrowsercompany/swift-build/actions/runs/11656344808/job/32454421580

Author: hyp

.github/workflows/swift-toolchain.yml

@@ -916,7 +916,7 @@ jobs:
           github-repo: thebrowsercompany/swift-build
           github-token: ${{ secrets.GITHUB_TOKEN }}
           release-asset-name: installer-amd64.exe
-          release-tag-name: '20240920.2'
+          release-tag-name: '20231016.5'
 
       - uses: nttld/setup-ndk@v1
         id: setup-ndk
@@ -1579,7 +1579,7 @@ jobs:
           github-repo: thebrowsercompany/swift-build
           github-token: ${{ secrets.GITHUB_TOKEN }}
           release-asset-name: installer-amd64.exe
-          release-tag-name: '20240920.2'
+          release-tag-name: '20231016.5'
 
       # NOTE(compnerd): we execute unconditionally as we use CMake from VSDevEnv
       - uses: compnerd/gha-setup-vsdevenv@main
@@ -2271,7 +2271,7 @@ jobs:
                 -D CMAKE_INSTALL_PREFIX=${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/${{ matrix.os }}.platform/Developer/Library/Testing-development/usr `
                 -D CMAKE_Swift_COMPILER=${SWIFTC} `
                 -D CMAKE_Swift_COMPILER_TARGET=${{ matrix.triple_no_api_level }} `
-                -D CMAKE_Swift_FLAGS="-resource-dir ${{ github.workspace }}/BinaryCache/Library/Developer/Platforms/${{ matrix.os }}.platform/Developer/SDKs/${{ matrix.os }}.sdk/usr/lib/swift -L${{ github.workspace }}/BinaryCache/Library/Developer/Platforms/${{ matrix.os }}.platform/Developer/SDKs/${{ matrix.os }}.sdk/usr/lib/swift/${{ matrix.os }} ${OVERLAY_FLAGS} ${{ matrix.swiftflags }}" `
+                -D CMAKE_Swift_FLAGS="-package-name swift_testing -resource-dir ${{ github.workspace }}/BinaryCache/Library/Developer/Platforms/${{ matrix.os }}.platform/Developer/SDKs/${{ matrix.os }}.sdk/usr/lib/swift -L${{ github.workspace }}/BinaryCache/Library/Developer/Platforms/${{ matrix.os }}.platform/Developer/SDKs/${{ matrix.os }}.sdk/usr/lib/swift/${{ matrix.os }} ${OVERLAY_FLAGS} ${{ matrix.swiftflags }}" `
                 -D CMAKE_Swift_FLAGS_RELEASE="-O" `
                 -D CMAKE_SYSTEM_NAME=${{ matrix.os }} `
                 -D CMAKE_SYSTEM_PROCESSOR=${CMAKE_CPU} `
@@ -3254,9 +3254,6 @@ jobs:
       - name: Install WixToolset.Sdk
         run: |
           if ((Get-Package -Name WixToolset.Sdk -ErrorAction SilentlyContinue) -eq $null) {
-            if ([string]::IsNullOrEmpty((Get-PackageSource | %{ $_.Location } | Select-String -Pattern api.nuget.org))) {
-              Register-PackageSource -Name NuGet -Location https://www.nuget.org/api/v2 -ProviderName NuGet
-            }
             Install-Package -Name WixToolset.Sdk -RequiredVersion 4.0.1 -Force
           }
 
@@ -3434,9 +3431,6 @@ jobs:
       - name: Install WixToolset.Sdk
         run: |
           if ((Get-Package -Name WixToolset.Sdk -ErrorAction SilentlyContinue) -eq $null) {
-            if ([string]::IsNullOrEmpty((Get-PackageSource | %{ $_.Location } | Select-String -Pattern api.nuget.org))) {
-              Register-PackageSource -Name NuGet -Location https://www.nuget.org/api/v2 -ProviderName NuGet
-            }
             Install-Package -Name WixToolset.Sdk -RequiredVersion 4.0.1 -Force
           }
 
@@ -3551,9 +3545,6 @@ jobs:
       - name: Install WixToolset.Sdk
         run: |
           if ((Get-Package -Name WixToolset.Sdk -ErrorAction SilentlyContinue) -eq $null) {
-            if ([string]::IsNullOrEmpty((Get-PackageSource | %{ $_.Location } | Select-String -Pattern api.nuget.org))) {
-              Register-PackageSource -Name NuGet -Location https://www.nuget.org/api/v2 -ProviderName NuGet
-            }
             Install-Package -Name WixToolset.Sdk -RequiredVersion 4.0.1 -Force
           }