fix(fs): don't impl MetadataExt on Windows

Author: Berrysoft

compio-fs/Cargo.toml

@@ -57,7 +57,3 @@ windows-sys = { workspace = true, features = ["Win32_Security_Authorization"] }
 # Unix specific dev dependencies
 [target.'cfg(unix)'.dev-dependencies]
 nix = { workspace = true, features = ["fs"] }
-
-[features]
-windows_by_handle = []
-nightly = ["windows_by_handle"]

compio-fs/src/lib.rs

@@ -2,10 +2,6 @@
 
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 #![warn(missing_docs)]
-#![cfg_attr(
-    all(windows, feature = "windows_by_handle"),
-    feature(windows_by_handle)
-)]
 
 mod file;
 pub use file::*;

compio-fs/src/metadata/windows.rs

@@ -1,6 +1,5 @@
 use std::{
     io,
-    os::windows::fs::MetadataExt,
     path::Path,
     time::{Duration, SystemTime},
 };
@@ -144,49 +143,50 @@ impl Metadata {
     pub fn created(&self) -> io::Result<SystemTime> {
         Ok(filetime_to_systemtime(self.stat.ftCreationTime))
     }
-}
 
-impl MetadataExt for Metadata {
-    fn file_attributes(&self) -> u32 {
+    /// Returns the value of the `dwFileAttributes` field of this metadata.
+    pub fn file_attributes(&self) -> u32 {
         self.stat.dwFileAttributes
     }
 
-    fn creation_time(&self) -> u64 {
+    /// Returns the value of the `ftCreationTime` field of this metadata.
+    pub fn creation_time(&self) -> u64 {
         filetime_u64(self.stat.ftCreationTime)
     }
 
-    fn last_access_time(&self) -> u64 {
+    /// Returns the value of the `ftLastAccessTime` field of this metadata.
+    pub fn last_access_time(&self) -> u64 {
         filetime_u64(self.stat.ftLastAccessTime)
     }
 
-    fn last_write_time(&self) -> u64 {
+    /// Returns the value of the `ftLastWriteTime` field of this metadata.
+    pub fn last_write_time(&self) -> u64 {
         filetime_u64(self.stat.ftLastWriteTime)
     }
 
-    fn file_size(&self) -> u64 {
-        self.len()
-    }
-
-    #[cfg(feature = "windows_by_handle")]
-    fn volume_serial_number(&self) -> Option<u32> {
+    /// Returns the value of the `dwVolumeSerialNumber` field of this
+    /// metadata.
+    pub fn volume_serial_number(&self) -> Option<u32> {
         if self.handle_info {
             Some(self.stat.dwVolumeSerialNumber)
         } else {
             None
         }
     }
 
-    #[cfg(feature = "windows_by_handle")]
-    fn number_of_links(&self) -> Option<u32> {
+    /// Returns the value of the `nNumberOfLinks` field of this
+    /// metadata.
+    pub fn number_of_links(&self) -> Option<u32> {
         if self.handle_info {
             Some(self.stat.nNumberOfLinks)
         } else {
             None
         }
     }
 
-    #[cfg(feature = "windows_by_handle")]
-    fn file_index(&self) -> Option<u64> {
+    /// Returns the value of the `nFileIndex{Low,High}` fields of this
+    /// metadata.
+    pub fn file_index(&self) -> Option<u64> {
         if self.handle_info {
             Some(create_u64(
                 self.stat.nFileIndexHigh,

compio/Cargo.toml

@@ -107,14 +107,12 @@ read_buf = [
     "compio-tls?/read_buf",
 ]
 try_trait_v2 = ["compio-buf/try_trait_v2"]
-windows_by_handle = ["compio-fs?/windows_by_handle"]
 nightly = [
     "allocator_api",
     "lazy_cell",
     "once_cell_try",
     "read_buf",
     "try_trait_v2",
-    "windows_by_handle",
 ]
 
 [[example]]