Skip to content

Commit 80b5da5

Browse files
Rollup merge of rust-lang#140910 - paolobarbolini:wasi-fs-incorrect-stabilization, r=joboet
Remove `stable` attribute from wasi fs (read_exact|write_all)_at The docs for [`std::os::wasi::fs::FileExt::read_exact_at`](https://doc.rust-lang.org/1.86.0/std/os/wasi/fs/trait.FileExt.html#method.read_exact_at) and [`std::os::wasi::fs::FileExt::write_all_at`](https://doc.rust-lang.org/1.86.0/std/os/wasi/fs/trait.FileExt.html#method.write_all_at) show the methods to be stable since v1.33, which is not correct and was a mistake made when the methods were added in (rust-lang#74076 (review)). The reviewer seemed to think this was an insta-stabilization, but the entire file is marked as unstable so that was not right. The stabilization version would also have been wrong either way.
2 parents 0ee8f1e + aeea472 commit 80b5da5

File tree

1 file changed

+0
-2
lines changed
  • library/std/src/os/wasi

1 file changed

+0
-2
lines changed

library/std/src/os/wasi/fs.rs

-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ pub trait FileExt {
7272
/// If this function returns an error, it is unspecified how many bytes it
7373
/// has read, but it will never read more than would be necessary to
7474
/// completely fill the buffer.
75-
#[stable(feature = "rw_exact_all_at", since = "1.33.0")]
7675
fn read_exact_at(&self, mut buf: &mut [u8], mut offset: u64) -> io::Result<()> {
7776
while !buf.is_empty() {
7877
match self.read_at(buf, offset) {
@@ -144,7 +143,6 @@ pub trait FileExt {
144143
/// non-[`io::ErrorKind::Interrupted`] kind that [`write_at`] returns.
145144
///
146145
/// [`write_at`]: FileExt::write_at
147-
#[stable(feature = "rw_exact_all_at", since = "1.33.0")]
148146
fn write_all_at(&self, mut buf: &[u8], mut offset: u64) -> io::Result<()> {
149147
while !buf.is_empty() {
150148
match self.write_at(buf, offset) {

0 commit comments

Comments
 (0)