Do not leak a TypedArray instance

yuvipanda · suchabot · commit 19f9aed040e3 · 2013-07-10T21:59:27.000Z
Change-Id: Ifea85ed88b7054af7b7f8c36ab90cdf9fca36597 GitHub: https://github.com/wikimedia/apps-android-commons/pull/26
diff --git a/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java b/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
@@ -52,6 +52,7 @@ public MediaWikiImageView(Context context, AttributeSet attrs) {
         this(context, attrs, 0);
         TypedArray actualAttrs = context.getTheme().obtainStyledAttributes(attrs, R.styleable.MediaWikiImageView, 0, 0);
         isThumbnail = actualAttrs.getBoolean(0, false);
+        actualAttrs.recycle();
     }
 
     public MediaWikiImageView(Context context, AttributeSet attrs, int defStyle) {

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ public MediaWikiImageView(Context context, AttributeSet attrs) {`
`52`	`52`	`this(context, attrs, 0);`
`53`	`53`	`TypedArray actualAttrs = context.getTheme().obtainStyledAttributes(attrs, R.styleable.MediaWikiImageView, 0, 0);`
`54`	`54`	`isThumbnail = actualAttrs.getBoolean(0, false);`
	`55`	`+ actualAttrs.recycle();`
`55`	`56`	`}`
`56`	`57`
`57`	`58`	`public MediaWikiImageView(Context context, AttributeSet attrs, int defStyle) {`