Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Commit 7d634a6

Browse files
bors[bot]bonomatFranck Royer
authored
Merge #2106
2106: Run e2e in parallel using jest r=bonomat a=bonomat Once done, resolves #1928 resolves #1927 (I'll create a follow-up ticket to run more tests in parallel see below. Note, running multiple tests using parity is hard because we would need a mutex around sending transaction -> nonce issue ) resolves #2137 99% review please: My assumption were: * we want to get rid of our custom test runner * we want to use jest * each test should have its own cnd nodes * tests share blockchain nodes Ticket #1927 was partially resolved. Some tests are run in parallel but not all of them. Tests within 1 tests suite (in the same file) are not run in parallel. With this setup we can't split up all blockchain based e2e tests in multiple files though. However, I have an idea how this can be resolved. I'll create a follow-up ticket on this once this PR is merged. In short we need to do this: 1. Start blockchain nodes and store settings in a config file 2. For each test suite 1. start a testenvironment which parses the config file and loads the settings into a global var 2. execute tests 3. Shutdown blockchain nodes after all tests # Open TODOs 0. [ ] re-organise blockchain tests per concern tested (happy, refund, etc) and then use it.each to loop through the assets/ledgers combinations. The suites should probably include the protocols as those determine, which actions you can take. 1. [ ] create a follow-up ticket for parallelizing blockchain-based e2e tests: this can be quite tricky as we use 1 account for ethereum (parity-dev account) to fund each actor 3. [ ] create a follow-up ticket for renaming e2e tests: test names are currently a bit messy and don't necessarily have to contain `-` in the name. Co-authored-by: Philipp Hoenisch <[email protected]> Co-authored-by: Franck Royer <[email protected]>
2 parents f1ced27 + c976953 commit 7d634a6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+4108
-1737
lines changed

api_tests/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ log
33
*.js
44
gen/
55
yarn-error.log
6+
dist/

api_tests/.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
gen/
2+
dist/

api_tests/dry/config.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

api_tests/dry/lightning_routes.ts

Lines changed: 0 additions & 63 deletions
This file was deleted.

api_tests/dry/peers_using_ip.ts

Lines changed: 0 additions & 111 deletions
This file was deleted.

api_tests/dry/rfc003_schema.ts

Lines changed: 0 additions & 91 deletions
This file was deleted.

0 commit comments

Comments
 (0)