OPIK-610 PR comments

Author: idoberko2

apps/opik-backend/config.yml

@@ -224,6 +224,12 @@ llmProviderClient:
   # Default: 60s
   # Description: Write timeout for LLM providers
   writeTimeout: ${LLM_PROVIDER_CLIENT_WRITE_TIMEOUT:-60s}
+  # Default: false
+  # Description: Whether or not to log requests
+  logRequests: ${LLM_PROVIDER_CLIENT_LOG_REQUESTS:-false}
+  # Default: false
+  # Description: Whether or not to log responses
+  logResponses: ${LLM_PROVIDER_CLIENT_LOG_RESPONSES:-false}
   # Configuration for OpenAI client
   openAiClient:
     # Default:
@@ -233,13 +239,7 @@ llmProviderClient:
   anthropicClient:
     # Default: https://api.anthropic.com/v1/
     # Description: Anthropic API base URL
-    baseUrl: ${LLM_PROVIDER_ANTHROPIC_BASE_URL:-https://api.anthropic.com/v1/}
+    url: ${LLM_PROVIDER_ANTHROPIC_BASE_URL:-https://api.anthropic.com/v1/}
     # Default: 2023-06-01
     # Description: Anthropic API version https://docs.anthropic.com/en/api/versioning
     version: ${LLM_PROVIDER_ANTHROPIC_VERSION:-'2023-06-01'}
-    # Default: false
-    # Description: Whether or not to log requests
-    logRequests: ${LLM_PROVIDER_ANTHROPIC_LOG_REQUESTS:-false}
-    # Default: false
-    # Description: Whether or not to log responses
-    logResponses: ${LLM_PROVIDER_ANTHROPIC_LOG_RESPONSES:-false}

apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderAnthropic.java

@@ -168,10 +168,10 @@ private ChatCompletionChoice toChatCompletionChoice(
     private AnthropicClient newClient(String apiKey) {
         var anthropicClientBuilder = AnthropicClient.builder();
         Optional.ofNullable(llmProviderClientConfig.getAnthropicClient())
-                .map(LlmProviderClientConfig.AnthropicClientConfig::baseUrl)
-                .ifPresent(baseUrl -> {
-                    if (StringUtils.isNotEmpty(baseUrl)) {
-                        anthropicClientBuilder.baseUrl(baseUrl);
+                .map(LlmProviderClientConfig.AnthropicClientConfig::url)
+                .ifPresent(url -> {
+                    if (StringUtils.isNotEmpty(url)) {
+                        anthropicClientBuilder.baseUrl(url);
                     }
                 });
         Optional.ofNullable(llmProviderClientConfig.getAnthropicClient())
@@ -181,11 +181,9 @@ private AnthropicClient newClient(String apiKey) {
                         anthropicClientBuilder.version(version);
                     }
                 });
-        Optional.ofNullable(llmProviderClientConfig.getAnthropicClient())
-                .map(LlmProviderClientConfig.AnthropicClientConfig::logRequests)
+        Optional.ofNullable(llmProviderClientConfig.getLogRequests())
                 .ifPresent(anthropicClientBuilder::logRequests);
-        Optional.ofNullable(llmProviderClientConfig.getAnthropicClient())
-                .map(LlmProviderClientConfig.AnthropicClientConfig::logResponses)
+        Optional.ofNullable(llmProviderClientConfig.getLogResponses())
                 .ifPresent(anthropicClientBuilder::logResponses);
         // anthropic client builder only receives one timeout variant
         Optional.ofNullable(llmProviderClientConfig.getCallTimeout())

apps/opik-backend/src/main/java/com/comet/opik/infrastructure/LlmProviderClientConfig.java

@@ -15,7 +15,7 @@ public class LlmProviderClientConfig {
     public record OpenAiClientConfig(String url) {
     }
 
-    public record AnthropicClientConfig(String baseUrl, String version, boolean logRequests, boolean logResponses) {
+    public record AnthropicClientConfig(String url, String version) {
     }
 
     @Min(1)
@@ -40,6 +40,10 @@ public record AnthropicClientConfig(String baseUrl, String version, boolean logR
     @MinDuration(value = 1, unit = TimeUnit.MILLISECONDS)
     private Duration writeTimeout;
 
+    private Boolean logRequests;
+
+    private Boolean logResponses;
+
     @Valid
     private LlmProviderClientConfig.OpenAiClientConfig openAiClient;
 

apps/opik-backend/src/test/resources/config-test.yml

@@ -187,6 +187,12 @@ llmProviderClient:
   # Default: 60s
   # Description: Call timeout for LLM providers
   callTimeout: 60s
+  # Default: false
+  # Description: Whether or not to log requests
+  logRequests: false
+  # Default: false
+  # Description: Whether or not to log responses
+  logResponses: false
   openAiClient:
     # See demo endpoint Langchain4j documentation: https://docs.langchain4j.dev/get-started
     # Not https but only used for testing purposes. It's fine as long as not sensitive data is sent.
@@ -195,13 +201,7 @@ llmProviderClient:
   anthropicClient:
     # Default: https://api.anthropic.com/v1/
     # Description: Anthropic API base URL
-    baseUrl: https://api.anthropic.com/v1/
+    url: https://api.anthropic.com/v1/
     # Default: 2023-06-01
     # Description: Anthropic API version https://docs.anthropic.com/en/api/versioning
     version: '2023-06-01'
-    # Default: false
-    # Description: Whether or not to log requests
-    logRequests: false
-    # Default: false
-    # Description: Whether or not to log responses
-    logResponses: false