#5 Resolved or ignored remaining warnings.

Author: dhendriks

checkstyle.xml

@@ -196,7 +196,9 @@ JavaBDD Checkstyle.
     <module name="DefaultComesLast"/>
     <module name="InnerAssignment">
       <metadata name="net.sf.eclipsecs.core.comment" value="Detects more than Eclipse JDT check."/>
+      <property name="severity" value="ignore"/>
       <message key="assignment.inner.avoid" value="Assignment in expression (inner assignment) should be avoided."/>
+      <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
     </module>
     <module name="ModifiedControlVariable">
       <property name="skipEnhancedForLoopVariable" value="true"/>

src/main/java/com/github/javabdd/BDDFactory.java

@@ -697,6 +697,7 @@ public BDD load(BufferedReader ifile, int[] translate) throws IOException {
             lh_table[pos].key = key;
             lh_table[pos].data = root;
         }
+        @SuppressWarnings("null")
         BDD tmproot = root.id();
 
         for (int n = 0; n < lh_nodenum; n++) {
@@ -2314,6 +2315,7 @@ protected static void bdd_default_reshandler(int oldsize, int newsize) {
         }
     }
 
+    @SuppressWarnings("deprecation")
     protected void registerCallback(List<Object[]> callbacks, Object o, Method m) {
         if (!Modifier.isPublic(m.getModifiers()) && !m.isAccessible()) {
             throw new BDDException("Callback method not accessible");

src/main/java/com/github/javabdd/FindBestOrder.java

@@ -124,6 +124,7 @@ public void writeBDDConfig(BDDFactory bdd, String fileName) throws IOException {
         }
     }
 
+    @SuppressWarnings("deprecation")
     public long tryOrder(boolean reverse, String varOrder) {
         System.gc();
         TryThread t = new TryThread();

src/main/java/com/github/javabdd/JFactory.java

@@ -706,7 +706,7 @@ public void setVarOrder(String ordering) {
         StringTokenizer st = new StringTokenizer(ordering, "x_", true);
         boolean[] done = new boolean[nDomains];
         List<BDDDomain> last = null;
-        for (/* int i=0 */;; /* ++i */) {
+        while (true) { // for (int i = 0 ;; ++i)
             String s = st.nextToken();
             BDDDomain d;
             for (int j = 0;; ++j) {