[cdt-98] - tests fixed

Signed-off-by: ashish <[email protected]>

Author: pateash

src/commands/showfile.ts

@@ -7,6 +7,7 @@ import Utilities from '../utilities/utilities'
 export default class ShowFile extends Command {
   static description = 'File Minifier'
 
+  static DEFAULT_COUNT = 10
   static flags = {
     help: flags.help({char: 'h'}),
     file: flags.string({char: 'f' , description: 'formatted file to be shown'}),
@@ -37,7 +38,10 @@ export default class ShowFile extends Command {
   }
 
   private getFileLinesToShow(flags: any) {
-    return flags.num || 10
+    if(flags.num && flags.num>0) // if value available and valid
+      return flags.num;
+    else
+      return ShowFile.DEFAULT_COUNT;
   }
   // tslint:disable-next-line:no-unused
   private checkParameters(flags: unknown, args: { [p: string]: any }) {

test/commands/showfile.test.ts

@@ -13,32 +13,33 @@ describe('showfile', () => {
     .stdout()
     .command(['showfile', 'test/resources/showfile.csv'])
     .it('check 10 lines are found', ctx => {
-      expect(ctx.stdout).to.contain('|1       |2     |1  |14.0             |30.0708|1           |0         |')
+      expect(ctx.stdout).to.contain('|1       |2     |1  |14.0             |30.0708|1           |0        |')
     })
   test
     .stdout()
     .command(['showfile', 'test/resources/showfile.csv', '-n', '5'])
     .it('check 5th line is found', ctx => {
-      expect(ctx.stdout).to.contain('|0       |3     |0  |35.0|8.05   |0           |0         |')
+      expect(ctx.stdout).to.contain('|0       |3     |0  |35.0|8.05   |0           |0        |')
     })
 
   test
     .stdout()
-    .command(['showfile', 'test/resources/showfile.csv', '-n', '900'])
+    .command (['showfile', 'test/resources/showfile.csv', '-n', '900'])
     .it('check if the given number is greater than total lines', ctx => {
-      expect(ctx.stdout).to.contain('|0       |3     |0  |32.0             |7.75    |0           |0         |')
+      expect(ctx.stdout).to.contain('|0       |3     |0  |32.0             |7.75    |0           |0        |')
     })
+
   test
     .stdout()
     .command(['showfile', 'test/resources/showfile.csv', '-n', '900'])
     .it('check if 900 count is used, it shows only total present rows', ctx => {
       expect(ctx.stdout).to.contain('showing top 892 rows.')
     })
+
   test
     .stdout()
     .command(['showfile', 'test/resources/showfile.csv', '-n', '0'])
-    .it('check if the given number is greater than total lines', ctx => {
-      expect(ctx.stdout).to.contain('|Survived|Pclass|Sex|Age|Fare|Family_count|Cabin_ind |')
+    .it('check if the given number is invalid then show default 10 lines', ctx => {
+      expect(ctx.stdout).to.contain('|1       |2     |1  |14.0             |30.0708|1           |0        |')
     })
-    //|Survived|Pclass|Sex|Age|Fare|Family_count|Cabin_ind |
 })