Refactor UniqueTranslationValidator

Author: ivanvermeyen

src/UniqueTranslationRule.php

@@ -2,35 +2,32 @@
 
 namespace CodeZero\UniqueTranslation;
 
-use DB;
-use Illuminate\Contracts\Validation\Rule;
-
-class UniqueTranslationRule implements Rule
+class UniqueTranslationRule
 {
     /**
      * @var string
      */
-    protected $table;
+    protected $rule = 'unique_translation';
 
     /**
      * @var string
      */
-    protected $column;
+    protected $table;
 
     /**
-     * @var string
+     * @var string|null
      */
-    protected $attribute;
+    protected $column = null;
 
     /**
      * @var mixed
      */
-    protected $ignoreValue;
+    protected $ignoreValue = null;
 
     /**
-     * @var string
+     * @var string|null
      */
-    protected $ignoreColumn;
+    protected $ignoreColumn = null;
 
     /**
      * Create a new rule instance.
@@ -61,50 +58,19 @@ public function ignore($value, $column = 'id')
     }
 
     /**
-     * Determine if the validation rule passes.
-     *
-     * @param string $attribute
-     * @param string $value
-     *
-     * @return bool
-     */
-    public function passes($attribute, $value)
-    {
-        $attributes = explode('.', $attribute);
-        $this->attribute = $attributes[0];
-        $this->column = $this->column ?: $attributes[0];
-        $locale = $attributes[1] ?? app()->getLocale();
-
-        return $this->isUnique($this->column, $locale, $value);
-    }
-
-    /**
-     * Get the validation error message.
+     * Generate a string representation of the validation rule.
      *
      * @return string
      */
-    public function message()
+    public function __toString()
     {
-        return trans('validation.unique');
-    }
-
-    /**
-     * Check if the given translated value does not exist in the database.
-     *
-     * @param string $column
-     * @param string $locale
-     * @param string $value
-     *
-     * @return bool
-     */
-    protected function isUnique($column, $locale, $value)
-    {
-        $query = DB::table($this->table)->where("{$column}->{$locale}", '=', $value);
-
-        if ($this->ignoreColumn !== null) {
-            $query = $query->where($this->ignoreColumn, '!=', $this->ignoreValue);
-        }
-
-        return $query->count() === 0;
+        return sprintf(
+            '%s:%s,%s,%s,%s',
+            $this->rule,
+            $this->table,
+            $this->column ?: 'NULL',
+            $this->ignoreValue ?: 'NULL',
+            $this->ignoreColumn ?: 'NULL'
+        );
     }
 }

src/UniqueTranslationValidator.php

@@ -21,11 +21,11 @@ public function validate($attribute, $value, $parameters, $validator) {
         $attribute = $attributeParts[0];
         $locale = $attributeParts[1] ?? app()->getLocale();
         $table = $parameters[0] ?? null;
-        $column = $parameters[1] ?? null;
-        $ignoreValue = $parameters[2] ?? null;
-        $ignoreColumn = $parameters[3] ?? null;
+        $column = $this->filterNullValues($parameters[1] ?? null) ?: $attribute;
+        $ignoreValue = $this->filterNullValues($parameters[2] ?? null);
+        $ignoreColumn = $this->filterNullValues($parameters[3] ?? null);
 
-        $isUnique = $this->isUnique($attribute, $locale, $value, $table, $column, $ignoreValue, $ignoreColumn);
+        $isUnique = $this->isUnique($value, $locale, $table, $column, $ignoreValue, $ignoreColumn);
 
         $validator->setCustomMessages([
             'unique_translation' => trans('validation.unique'),
@@ -34,23 +34,38 @@ public function validate($attribute, $value, $parameters, $validator) {
         return $isUnique;
     }
 
+    /**
+     * Filter NULL values.
+     *
+     * @param string|null $value
+     *
+     * @return string|null
+     */
+    protected function filterNullValues($value)
+    {
+        $nullValues = ['null', 'NULL'];
+
+        if (in_array($value, $nullValues)) {
+            return null;
+        }
+
+        return $value;
+    }
+
     /**
      * Check if a translation is unique.
      *
-     * @param string $attribute
-     * @param string $locale
      * @param mixed $value
+     * @param string $locale
      * @param string $table
-     * @param string|null $column
+     * @param string $column
      * @param mixed $ignoreValue
      * @param string|null $ignoreColumn
      *
      * @return bool
      */
-    protected function isUnique($attribute, $locale, $value, $table, $column = null, $ignoreValue = null, $ignoreColumn = null)
+    protected function isUnique($value, $locale, $table, $column, $ignoreValue = null, $ignoreColumn = null)
     {
-        $column = $column ?: $attribute;
-
         $query = $this->findTranslation($table, $column, $locale, $value);
         $query = $this->ignore($query, $ignoreColumn, $ignoreValue);