Skip to content

Commit 3ffc090

Browse files
committed
do not crash when clicking on non station space
1 parent 271c26e commit 3ffc090

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

Changelog

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
2021-03-23 s-n-g
1+
2021-03-30 s-n-g
22
* Implemented a simplified method to install, update, uninstall.
33
* PyRadio will detect its player abnormal termination.
44
* Player's connection timeout can now be disabled. Once a player is
55
started, it will be considered to be connected immediately.
6-
* Active players parameter list is always synchronized to saved.
6+
* BUG FIX: Active players parameter list is always synchronized to saved.
7+
* BUG FIX: Clicking on empty space (past last station) will not crash pyradio.
78

89
2021-02-27 s-n-g
910
* Version 0.8.8.5 (BUG FIX release)

README.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ <h2 id="packaging-pyradio">Packaging Pyradio <span style="padding-left: 10px;"><
566566
<p>For example, an <strong>Arch Linux</strong> packager would use this command:</p>
567567
<pre>sed -i &#39;s/distro = None/distro = Arch Linux&#39; pyradio/config</pre>
568568
<p>The distro name you insert here will appear in <strong>PyRadio</strong>’s “<em>Configuration Window</em>”. In addition to that it will appear in the log file, so that I know where the package came from while debugging.</p>
569-
<p>Having siad that, if you are not packaging for a specific distribution, please do use something meaningful (for example, using “<em>xxx</em>” will do the job, but provides no useful information).</p>
569+
<p>Having said that, if you are not packaging for a specific distribution, please do use something meaningful (for example, using “<em>xxx</em>” will do the job, but provides no useful information).</p>
570570
<h2 id="todo">TODO <span style="padding-left: 10px;"><sup style="font-size: 50%"><a href="#" title="Go to top of the page">Top</a></sup></style></h2>
571571
<ul class="task-list">
572572
<li><input type="checkbox" disabled="" />
@@ -580,7 +580,7 @@ <h2 id="todo">TODO <span style="padding-left: 10px;"><sup style="font-size: 50%"
580580
<li><input type="checkbox" disabled="" />
581581
Notify the user that the package’s stations.csv has changed</li>
582582
<li><input type="checkbox" disabled="" checked="" />
583-
Update / uninstall using command line parameters (-U / -R) - v. 0.9.0</li>
583+
Update / uninstall using command line parameters (-U / -R) - v. 0.8.9</li>
584584
<li><input type="checkbox" disabled="" />
585585
Use Radio Browser service (<a target="_blank" href="https://github.com/coderholic/pyradio/issues/80">#80</a> <a target="_blank" href="https://github.com/coderholic/pyradio/issues/93">#93</a> <a target="_blank" href="https://github.com/coderholic/pyradio/issues/112">#112</a>)</li>
586586
</ul>

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ sed -i 's/distro = None/distro = Arch Linux' pyradio/config
742742

743743
The distro name you insert here will appear in **PyRadio**'s "*Configuration Window*". In addition to that it will appear in the log file, so that I know where the package came from while debugging.
744744

745-
Having siad that, if you are not packaging for a specific distribution, please do use something meaningful (for example, using "*xxx*" will do the job, but provides no useful information).
745+
Having said that, if you are not packaging for a specific distribution, please do use something meaningful (for example, using "*xxx*" will do the job, but provides no useful information).
746746

747747
## TODO
748748

@@ -751,7 +751,7 @@ Having siad that, if you are not packaging for a specific distribution, please d
751751
- [x] Players extra parameters ([#118](https://github.com/coderholic/pyradio/issues/118)) - v. 0.8.8.3
752752
- [x] New player selection configuration window ([#118](https://github.com/coderholic/pyradio/issues/118)) - v. 0.8.8.3
753753
- [ ] Notify the user that the package's stations.csv has changed
754-
- [x] Update / uninstall using command line parameters (-U / -R) - v. 0.9.0
754+
- [x] Update / uninstall using command line parameters (-U / -R) - v. 0.8.9
755755
- [ ] Use Radio Browser service ([#80](https://github.com/coderholic/pyradio/issues/80) [#93](https://github.com/coderholic/pyradio/issues/93) [#112](https://github.com/coderholic/pyradio/issues/112))
756756

757757
## Acknowledgment

pyradio/radio.py

+2
Original file line numberDiff line numberDiff line change
@@ -3776,6 +3776,8 @@ def _handle_main_window_mouse_event(self, my, mx, a_button):
37763776
or a_button & curses.BUTTON1_CLICKED \
37773777
or a_button & curses.BUTTON1_RELEASED:
37783778
new_selection = self.startPos + my - self.bodyWinStartY
3779+
if new_selection >= self.number_of_items:
3780+
return False, False
37793781
if new_selection == self.selection:
37803782
do_update = False
37813783
else:

0 commit comments

Comments
 (0)