version 0.9.2.7

Author: s-n-g

Changelog

@@ -1,3 +1,10 @@
+2023-06-05 s-n-g
+    * version 0.9.2.7
+    * fixing a couple of install.py potential crashes
+    * fixing a theme download potential crash
+    * theme transparency will always be honored, in contrast
+      to global (config transparency setting)
+
 2023-05-08 s-n-g
     * version 0.9.2.6
     * using pipx for installation on "externally-managed"

README.html

@@ -206,6 +206,13 @@ <h2 id="requirements">Requirements <span style="padding-left: 10px;"><sup style=
 <h2 id="changelog">Changelog <span style="padding-left: 10px;"><sup style="font-size: 50%"><a href="#" title="Go to top of the page">Top</a></sup></span></h2>
 <pre style="height: 200px;">
 
+2023-06-05 s-n-g
+    * version 0.9.2.7
+    * fixing a couple of install.py potential crashes
+    * fixing a theme download potential crash
+    * theme transparency will always be honored, in contrast
+      to global (config transparency setting)
+
 2023-05-08 s-n-g
     * version 0.9.2.6
     * using pipx for installation on "externally-managed"
@@ -1637,9 +1644,9 @@ <h2 id="pyradio-themes">PyRadio Themes <span style="padding-left: 10px;"><sup st
 
 # Theme Transparency
 # Values are:
-#   0: No transparency (default)
+#   0: No transparency
 #   1: Theme is transparent
-#   2: Obey config setting
+#   2: Obey config setting (default)
 transparency        0</pre>
 <p>Pressing “<strong>t</strong>” will bring up the <em>Theme selection window</em>, which can be used to activate a theme and set the default one.</p>
 <p style="margin: 1.5em 4em 0 4em; text-indent: -2.5em;"><strong>Note:</strong> If the theme selected in the “<em>Theme selection window</em>”, (or requested using the “<strong>-t</strong>” command line option), is in any way invalid, or is of the old format, <strong>PyRadio</strong> will fall-back to the “<strong>dark</strong>” theme and will display a relevant message.</p>
@@ -1734,12 +1741,14 @@ <h3 id="using-transparency">Using transparency</h3>
 <p>For <strong>PyRadio</strong>, transparency means that a theme’s background actually disappears, effectively making it to display whatever is on the terminal (color/picture/transparency). The visual result depends on terminal settings and whether a compositor is running.</p>
 <p>Not all themes look good when transparency is ON, so themes can now declare whether they want to use transparency or not. This is the “<strong>transparency</strong>” variable of the theme, which can have these values:</p>
 <ul>
-<li>0 means that the theme looks better with no transparency (default)</li>
-<li>1 means that the theme looks better when transparency in ON</li>
-<li>2 means that the theme looks good either way, and the global transparency setting (defined in <strong>PyRadio</strong> config file) can be used.</li>
+<li>0 means that the theme will be opaque (no transparency)</li>
+<li>1 means that the theme will be transparent</li>
+<li>2 means that the theme looks good either way (the default), and the global transparency setting value (defined in <strong>PyRadio</strong> config file) will be used.</li>
 </ul>
-<p>Please notice that this is just a hint; themes will obey the rules above, but transparency can still be toggled using “<strong>T</strong>” (capital “<strong>t</strong>”).</p>
-<p>When the “<em>Theme selection window</em>” is visible, a “<strong>[T]</strong>” string displayed at its bottom right corner will indicate that transparency is <em>on</em>.</p>
+<p>Please note that this behavior has changed since <strong>v. 0.9.2.7</strong>: theme transparency will always be honored, regardless of the global config value.</p>
+<p>This means that a theme which is set to be transparent (by its creator) will always be transparent, no matter if the global transparency is on or off. Similarly, if a theme is set to be opaque, it will be so regardless of the global transparency value.</p>
+<p>The only case when global transparency will come into play is when the theme does not care about it (theme transparency set to 2 - Obey config setting).</p>
+<p>When the “<em>Theme selection window</em>” is visible, a “<strong>[T]</strong>” string displayed at its bottom right corner will indicate that global transparency is “<em>ON</em>”.</p>
 <h3 id="updating-themes-automatically">Updating themes automatically</h3>
 <p>Terminal users have been using all kind of software to change / update / adapt their terminal colors and palettes, such as <a target="_blank" href="https://github.com/chriskempson/base16">bASE16</a>, <a target="_blank" href="https://github.com/dylanaraps/pywal">pywal</a>, <a target="_blank" href="https://github.com/deviantfero/wpgtk">wpgtk</a>, <a target="_blank" href="https://github.com/lemnos/theme.sh">theme.sh</a>, to name a few.</p>
 <p><strong>PyRadio</strong> is now able to “watch” a given theme for changes and update its colors whenever the theme changes.</p>

README.md

@@ -939,9 +939,9 @@ Messages Border     #a3b367
 
 # Theme Transparency
 # Values are:
-#   0: No transparency (default)
+#   0: No transparency
 #   1: Theme is transparent
-#   2: Obey config setting
+#   2: Obey config setting (default)
 transparency        0
 ```
 
@@ -1096,13 +1096,17 @@ For **PyRadio**, transparency means that a theme's background actually disappear
 
 Not all themes look good when transparency is ON, so themes can now declare whether they want to use transparency or not. This is the "**transparency**" variable of the theme, which can have these values:
 
-- 0 means that the theme looks better with no transparency (default)
-- 1 means that the theme looks better when transparency in ON
-- 2 means that the theme looks good either way, and the global transparency setting (defined in **PyRadio** config file) can be used.
+- 0 means that the theme will be opaque (no transparency)
+- 1 means that the theme will be transparent
+- 2 means that the theme looks good either way (the default), and the global transparency setting value (defined in **PyRadio** config file) will be used.
 
-Please notice that this is just a hint; themes will obey the rules above, but transparency can still be toggled using "**T**" (capital "**t**").
+Please note that this behavior has changed since **v. 0.9.2.7**: theme transparency will always be honored, regardless of the global config value.
 
-When the "*Theme selection window*" is visible, a "**[T]**" string displayed  at  its  bottom right corner will indicate that transparency is *on*.
+This means that a theme which is set to be transparent (by its creator) will always be transparent, no matter if the global transparency is on or off. Similarly, if a theme is set to be opaque, it will be so regardless of the global transparency value.
+
+The only case when global transparency will come into play is when the theme does not care about it (theme transparency set to 2 - Obey config setting).
+
+When the "*Theme selection window*" is visible, a "**[T]**" string displayed  at  its  bottom right corner will indicate that global transparency is "*ON*".
 
 ### Updating themes automatically
 

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyradio"
-version = "0.9.2.6"
+version = "0.9.2.7"
 authors = [
   { name="Ben Dowling", email="[email protected]" },
   { name="Spiros Georgaras", email="[email protected]" },

pyradio.1

@@ -2,7 +2,7 @@
 .\" Copyright (C) 2018-2023 Spiros Georgaras <[email protected]>
 .\" This manual is freely distributable under the terms of the GPL.
 .\"
-.TH pyradio 1 "May 2023" pyradio
+.TH pyradio 1 "June 2023" pyradio
 
 .SH Name
 .PP
@@ -1263,19 +1263,23 @@ Not all themes look good when transparency is ON, so themes can now declare whet
 
 .RS 5
 .IP \fI0\fR 3
-means that the theme looks better with no transparency (default)
+means that the theme will be opaque (no transparency).
 
 .IP \fI1\fR 3
-means that the theme looks better when transparency in ON
+means that the theme will be transparent.
 
 .IP \fI2\fR 3
-means that the theme looks good either way, and the global transparency setting (defined in \fBpyrRadio\fR config file) can be used.
+- 2 means that the theme looks good either way (the default), and the global transparency setting value (defined in \fBpyradio\fR config file) will be used.
 
 .RE
 .PP
-Please notice that this is just a hint; themes will obey the rules above, but transparency can still be toggled using "\fIT\fR" (capital "\fIt\fR").
+Please note that this behavior has changed since \fBv. 0.9.2.7\fR: theme transparency will always be honored, regardless of the global config value.
 
-When the \fITheme selection window\fR is visible, a "\fI[T]\fR" string displayed at its bottom right corner will indicate that transparency is \fIon\fR.
+This means that a theme which is set to be transparent (by its creator) will always be transparent, no matter if the global transparency is on or off. Similarly, if a theme is set to be opaque, it will be so regardless of the global transparency value.
+
+The only case when global transparency will come into play is when the theme does not care about it (theme transparency set to \fI2 \fR- \fIObey config setting\fR).
+
+When the \fITheme selection window\fR is visible, a "\fI[T]\fR" string displayed at its bottom right corner will indicate that global transparency is \fIon\fR.
 .RE
 
 \fBUpdating themes automatically\fR

pyradio/__init__.py

@@ -1,6 +1,6 @@
 " pyradio -- Console radio player. "
 
-version_info = (0, 9, 2, 6)
+version_info = (0, 9, 2, 7)
 
 # Set it to True if new stations have been
 # added to the package's stations.csv

pyradio/config_window.py

@@ -78,7 +78,7 @@ class PyRadioConfigWindow(object):
     'This is the equivalent to the -t , --theme command line option.', '|',
     'If a theme uses more colors than those supported by the terminal in use, the "dark" theme will be used instead (but the "light" theme will be used, if the "light_16colors" theme was requested but not supported).',
     '|', 'Default value = dark'])
-    _help_text.append(['If False, theme colors will be used.', '|',
+    _help_text.append(['This option will work when a theme\'s transparency value is set to 2 (Obey config setting), the default. Otherwise, it\'s up to the theme to handle transparency.', '|', 'If False, theme colors will be used.', '|',
     "If True and a compositor is running, the stations' window background will be transparent.", '|', "If True and a compositor is not running, the terminal's background color will be used.", '|', 'Default value: False'])
     _help_text.append(['Pyradio can calculate and use an alternative color for secondary windows.', '|', 'This option will determine if this color will be used (value > 0) or not (value = 0), provided that the theme used does not already provide it.', '|', 'The value of this option is actually the factor to darken or lighten the main (stations) background color.', '|', 'You can get more info on this at https://github.com/coderholic/pyradio#secondary-windows-background', '|', 'Valid Values: 0-0.2', 'Default value: 0'])
     _help_text.append(None)

pyradio/install.py

@@ -15,7 +15,7 @@
 ''' This is PyRadio version this
     install.py was released for
 '''
-PyRadioInstallPyReleaseVersion = '0.9.2.6'
+PyRadioInstallPyReleaseVersion = '0.9.2.7'
 
 import locale
 locale.setlocale(locale.LC_ALL, "")

pyradio/radio.py

@@ -2363,7 +2363,6 @@ def _show_theme_selector(self, changed_from_config=False):
             self._theme_name,
             self._cnf.theme,
             11, 3, 11, 10, 6, 9,
-            self._theme.calculate_transparency(),
             self._cnf.auto_update_theme,
             self._watch_theme_lock
         )

pyradio/themes.py

@@ -814,9 +814,6 @@ class PyRadioThemeSelector(object):
     _max_title_width = 20
     _categories = 1
 
-    transparent = False
-    _transparent = False
-
     _showed = False
 
     changed_from_config = False
@@ -827,7 +824,7 @@ def __init__(self, parent, config, theme,
                  title_color_pair, box_color_pair,
                  applied_color_pair, normal_color_pair,
                  cursor_color_pair, applied_cursor_color_pair,
-                 is_transparent, is_watched, a_lock, log_file=''):
+                 is_watched, a_lock, log_file=''):
         self.parent = parent
         self._cnf = config
         self._theme = theme
@@ -839,7 +836,6 @@ def __init__(self, parent, config, theme,
         self._applied_cursor_color_pair = applied_cursor_color_pair
         self._applied_color_pair = applied_color_pair
         self._normal_color_pair = normal_color_pair
-        self._transparent = is_transparent
         self._theme_is_watched = is_watched
         self._watch_theme_lock = a_lock
         self._watch_theme_lock.acquire()
@@ -1064,12 +1060,11 @@ def getmaxyx(self):
 
     @property
     def transparent(self):
-        return self._transparent
+        return self._cnf.use_transparency
 
     @transparent.setter
     def transparent(self, val):
-        self._transparent = val
-        self.refresh()
+        return
 
     @property
     def selection(self):
@@ -1176,7 +1171,7 @@ def refresh(self):
         except:
             pass
         ''' display transparency indicator '''
-        if self._transparent:
+        if self._cnf.use_transparency:
             self._win.addstr(self._height-1, self._width - 4, '[T]', curses.color_pair(self._box_color_pair))
         else:
             try: