- working on pylint unused-cariable warnings

- working on ruff unused import worning

Author: s-n-g

pyradio/browser.py

@@ -722,7 +722,7 @@ def search(self, go_back_in_history=True):
 
     def next_page(self, msg_function=None):
         self._page += 1
-        post_data = self._get_post_data()
+        # post_data = self._get_post_data()
         if self.current_search_limit > len(self._raw_stations):
             self._page -= 1
             return '___No more results available!___'
@@ -944,7 +944,7 @@ def format_empty_line(self, width):
 
         out = ['', '']
         i_out = []
-        for i, n in enumerate(info[self._output_format]):
+        for n in info[self._output_format]:
             i_out.append(u'│' + ' ' * self._columns_width[n])
         out[1] = ''.join(i_out)
 
@@ -1838,7 +1838,7 @@ def __init__(
         '''
         self._cannot_delete_function = cannot_delete_function
         if len(self._params) == 0:
-            for i in range(0, 3):
+            for _ in range(0, 3):
                 self._params.append(
                     {'auto_save': False,
                      'server': '',
@@ -3488,7 +3488,7 @@ def _handle_new_or_existing_search_term(self):
         '''
         test_search_term = self._widgets_to_search_term()
         if test_search_term:
-            found, index = self._get_search_term_index(test_search_term)
+            _, index = self._get_search_term_index(test_search_term)
             # TODO: check if item is altered
             self._selected_history_id = index
             self._print_history_legend()
@@ -3959,7 +3959,7 @@ def set_active_by_value(self, a_string, set_selection=True):
     def show(self, parent=None):
         self._too_small = False
         pY, pX = self._parent.getmaxyx()
-        Y, X = self._parent.getbegyx()
+        Y, _ = self._parent.getbegyx()
         if self.maxY > pY or self.maxX > pX -2:
             self._too_small = True
             msg = 'Window too small to display content!'
@@ -4135,7 +4135,7 @@ def show(self, parent=None):
             self.servers._parent = parent
         self._too_small = False
         pY, pX = self._parent.getmaxyx()
-        Y, X = self._parent.getbegyx()
+        Y, _ = self._parent.getbegyx()
         if pX < 80 or pY < 22:
             self._too_small = True
             msg = 'Window too small to display content!'
@@ -4596,7 +4596,6 @@ def selection(self):
 
     @selection.setter
     def selection(self, val):
-        old_selection = self._selection
         if 0 <= val < len(self._items):
             self._selection = val
             self.show()

pyradio/cjkwrap.py

@@ -28,7 +28,6 @@
 
 import textwrap
 import unicodedata
-import sys
 
 import locale
 locale.setlocale(locale.LC_ALL, "")

pyradio/client.py

@@ -1,5 +1,4 @@
 # -*- coding: utf-8 -*-
-import argparse
 from argparse import ArgumentParser, SUPPRESS as SUPPRESS
 from os import path, getenv
 import sys
@@ -87,7 +86,7 @@ def server_port(self):
 
     @property
     def server_found(self):
-        return False if self._file is None else True
+        return self._file is not None
 
     @property
     def last_command(self):
@@ -241,7 +240,6 @@ def __init(self):
     def print_usage(self, file=None):
         if file is None:
             file = sys.stdout
-        usage = self.format_usage()
         print(self._add_colors(self.format_usage()))
 
     def print_help(self, file=None):

pyradio/common.py

@@ -4,20 +4,20 @@
 import io
 import csv
 import curses
-from sys import version as sys_version
 from os import rename, remove, access, X_OK
 from os.path import exists, dirname, join
 from shutil import which
-from copy import deepcopy
 from rich import print
 
 logger = logging.getLogger(__name__)
 
 locale.setlocale(locale.LC_ALL, "")
 
 """ Theming constants """
-def FOREGROUND(): return 0
-def BACKGROUND(): return 1
+def FOREGROUND():
+    return 0
+def BACKGROUND():
+    return 1
 
 # for pop up window
 CAPTION = 2
@@ -59,7 +59,7 @@ def BACKGROUND(): return 1
                            ': Playback stopped',
                            ': Player terminated abnormally!')
 
-def erase_curses_win(self, Y, X, beginY, beginX, char=' ', color=5):
+def erase_curses_win(Y, X, beginY, beginX, char=' ', color=5):
     ''' empty a part of the screen
     '''
     empty_win = curses.newwin(
@@ -199,8 +199,8 @@ def _read_synced_version(self, asked=False):
         # print('in_file = "{}"'.format(in_file))
         if exists(in_file):
             try:
-                with open(in_file, 'r', encoding='utf-8') as l:
-                    line = l.readline().strip()
+                with open(in_file, 'r', encoding='utf-8') as sync_file:
+                    line = sync_file.readline().strip()
                     return eval(line)
             except:
                 pass
@@ -209,8 +209,8 @@ def _read_synced_version(self, asked=False):
     def write_synced_version(self, asked=False):
         out_file = self._asked_sync_file if asked else self._last_sync_file
         try:
-            with open(out_file, 'w', encoding='utf-8') as l:
-                l.write(self.version_to_write)
+            with open(out_file, 'w', encoding='utf-8') as sync_file:
+                sync_file.write(self.version_to_write)
         except:
             return -5 if asked else -6
         return -3 if asked else 0
@@ -346,8 +346,8 @@ def stations_csv_needs_sync(self, print_messages=True, stop=None):
                 return False
         if exists(self._last_sync_file):
             try:
-                with open(self._last_sync_file, 'r', encoding='utf-8') as l:
-                    line = l.readline().strip()
+                with open(self._last_sync_file, 'r', encoding='utf-8') as sync_file:
+                    line = sync_file.readline().strip()
                     self.last_sync = eval(line)
             except:
                 ret = False

pyradio/config.py

@@ -8,7 +8,7 @@
 import collections
 import json
 # import socket
-from os import path, getenv, makedirs, remove, rename, readlink, SEEK_END, SEEK_CUR, environ, getpid, listdir, rmdir
+from os import path, getenv, makedirs, remove, rename, readlink, SEEK_END, SEEK_CUR, getpid, listdir
 from sys import platform
 from time import ctime, sleep
 from datetime import datetime
@@ -23,7 +23,7 @@
 from pyradio import version, stations_updated
 from .common import validate_resource_opener_path
 from .keyboard import kbkey, read_keyboard_shortcuts
-from .browser import PyRadioStationsBrowser, probeBrowsers
+from .browser import probeBrowsers
 from .install import get_github_long_description
 from .common import is_rasberrypi
 from .player import pywhich
@@ -602,7 +602,7 @@ def _get_playlist_abspath_from_data(self, stationFile=''):
                     ''' negative playlist number '''
                     return '', -3
                 else:
-                    n, f = self.read_playlists()
+                    n, _ = self.read_playlists()
                     if sel <= n-1:
                         stationFile = self.playlists[sel][-1]
                         return stationFile, 0
@@ -1108,10 +1108,6 @@ def move_station(self, source, target):
                 self.number_of_stations == 0:
             # logger.error('DE \n\nreturning False\n\n')
             return False
-        if source < target:
-            step = 1
-        else:
-            step = 0
         d = collections.deque(self.stations)
         d.rotate(-source)
         source_item = d.popleft()
@@ -1178,7 +1174,7 @@ def read_playlists(self):
         return len(self.playlists), self.selected_playlist
 
     def list_playlists(self):
-        num_of_playlists, selected_playlist = self.read_playlists()
+        self.read_playlists()
         console = Console()
 
         table = Table(show_header=True, header_style="bold magenta")
@@ -1466,9 +1462,6 @@ def __init__(self, user_config_dir=None, headless=False):
 
         self._read_notification_command()
 
-        ''' function to return a player instance '''
-        player_instance = None
-
     @property
     def linux_resource_opener(self):
         return self._linux_resource_opener
@@ -1605,7 +1598,7 @@ def calculated_color_factor(self):
     @calculated_color_factor.setter
     def calculated_color_factor(self, value):
         try:
-            test = float(str(value))
+            float(str(value))
             self.opts['calculated_color_factor'][1] = str(value)
         except (ValueError, TypeError, NameError):
             self.opts['calculated_color_factor'][1] = '0'
@@ -1979,7 +1972,7 @@ def _get_lock_file(self):
         else:
             if not self.headless:
                 try:
-                    with open(self._session_lock_file, 'w', encoding='utf-8') as f:
+                    with open(self._session_lock_file, 'w', encoding='utf-8'):
                         pass
                 except:
                     pass
@@ -2095,7 +2088,6 @@ def _validate_remote_control_server_ip(self, val):
             ''' is server valid '''
             if sp[0].startswith('*'):
                 sp[0] = sp[0][1:]
-                auto = True
             x = [r for r in hosts if r == sp[0]]
             if not x:
                 return default_remote_control_server
@@ -2164,7 +2156,7 @@ def _read_config(self, distro_config=False):
                 return -2
             if sp[1] == '':
                 return -2
-            for i, n in enumerate(sp):
+            for i in range(len(sp)):
                 sp[i] = sp[i].strip()
             if sp[0] == 'show_no_themes_message':
                 self.show_no_themes_message = True
@@ -2800,7 +2792,7 @@ def save_config(self, from_command_line=False):
             # fix self.saved_params (remove profiles)
             profiles_params_changed = False
             for a_key in self.saved_params.keys():
-                the_id = self.saved_params[a_key][0]
+                # the_id = self.saved_params[a_key][0]
                 the_profile = self.saved_params[a_key][self.saved_params[a_key][0]]
                 # logger.error('\n\na_key = {0}\nthe_id = {1}\nthe_profile = {2}\n\n'.format(a_key, the_id, the_profile))
                 for i in range(len(self.saved_params[a_key])-1, 0, -1):
@@ -2872,7 +2864,6 @@ def is_blacklisted_terminal(self):
                 read ~/.config/pyradio/no-themes-terminals
                 '''
                 term_file = path.join(self.stations_dir, 'no-themes-terminals')
-                user_terminal = []
                 if path.exists(term_file):
                     try:
                         with open(term_file, 'r', encoding='utf-8') as term:
@@ -3568,7 +3559,6 @@ def download(self, a_theme=None, a_path=None, print_errors=None):
             # logger.error('w_path = {}'.format(w_path))
             requests_response = None
             written = False
-            line_num = 1
             for n in range(0,5):
                 requests_response = None
                 try:
@@ -3583,7 +3573,7 @@ def download(self, a_theme=None, a_path=None, print_errors=None):
                         if print_errors is not None:
                             print_errors.addstr(n + 1, 0, '  download failed, retrying...', curses.color_pair(0))
                             print_errors.refresh()
-                except requests.exceptions.RequestException as e:
+                except requests.exceptions.RequestException:
                     if print_errors is not None:
                         print_errors.addstr(n + 1, 0, '  download failed, retrying...', curses.color_pair(0))
                         print_errors.refresh()

pyradio/config_window.py

@@ -6,7 +6,7 @@
 from textwrap import wrap
 import glob
 import csv
-from os import path, sep, remove
+from os import path, sep
 from sys import platform, version_info
 
 from .common import *
@@ -469,8 +469,8 @@ def _put_cursor(self, jump):
             return
         visible_items = self.maxY - 3
         last_item = self._start + visible_items
-        old_selection = self.__selection
-        old_start = self._start
+        # old_selection = self.__selection
+        # old_start = self._start
         self.__selection += jump
         if jump >= 0:
             if self.__selection in self._headers:
@@ -648,8 +648,8 @@ def _go_default(self):
 
     def _go_saved(self):
         self.load_default_or_saved_parameters = True
-        old_theme = self._config_options['theme'][1]
-        old_transparency = self._config_options['use_transparency'][1]
+        # old_theme = self._config_options['theme'][1]
+        # old_transparency = self._config_options['use_transparency'][1]
         self._config_options = deepcopy(self._saved_config_options)
         self._config_options['recording_dir'][1] = self._orig_redording_dir
         if self._cnf.use_themes:
@@ -1799,7 +1799,7 @@ def _list_to_dict(self):
             self._working_params[a_params_set] = the_list[:]
 
     def _get_width(self):
-        Y, X = self._win.getmaxyx()
+        _, X = self._win.getmaxyx()
         self._width = X - self.startX - 2
 
     def refresh_win(self, do_show=True):
@@ -2569,7 +2569,7 @@ def _set_startPos(self):
             self.startPos = 0
 
     def _resize(self, init=False):
-        col, row = self._selection_to_col_row(self.selection)
+        _, row = self._selection_to_col_row(self.selection)
         if not (self.startPos <= row <= self.startPos + self.list_maxY - 1):
             while row > self.startPos:
                 self.startPos += 1
@@ -2610,7 +2610,7 @@ def in_alias(a_list, a_string):
         return -1
 
     def _fix_startPos(self, direction=1):
-        col, row = self._selection_to_col_row(self.selection)
+        _, row = self._selection_to_col_row(self.selection)
         startRow = self.startPos
         endRow = self.startPos + self.list_maxY - 1
         if not (startRow <= row <= endRow):

pyradio/edit.py

@@ -914,9 +914,9 @@ def _string_changed(self):
                 if stripped_string.startswith(self._orig_path + sep):
                     self._error_string = 'Invalid dir_path!!!'
                 else:
-                    l = [x for x in self._invalid_chars if x in stripped_string]
+                    err_list = [x for x in self._invalid_chars if x in stripped_string]
                     # logger.error('l = {}'.format(l))
-                    if l:
+                    if err_list:
                         self._error_string = 'Invalid dir_path!!!'
             self._widgets[-2].enabled = False
             if stripped_string and self._error_string == '':
@@ -1347,9 +1347,9 @@ def _string_changed(self):
                     if w_file is None:
                         self._error_string = 'Invalid opener!!!'
                     else:
-                        l = [x for x in self._invalid_chars if x in stripped_string]
+                        err_list = [x for x in self._invalid_chars if x in stripped_string]
                         # logger.error('l = {}'.format(l))
-                        if l:
+                        if err_list:
                             self._error_string = 'Invalid opener!!!'
                 self._widgets[-2].enabled = False
                 if w_file and self._error_string == '':

pyradio/html_help.py

@@ -128,7 +128,7 @@ def _open_file(self, a_file, linux_resource_opener=None):
             if logger.isEnabledFor(logging.DEBUG):
                 logger.debug('HtmlHelp: executing: "{}"'.format(cmd))
             try:
-                p = subprocess.Popen(
+                 subprocess.Popen(
                         cmd,
                         shell=False,
                         stdout=subprocess.PIPE,