- version 0.9.2.4

- do not crash when we have a small number of Groups
- get a minimum size so that we don't get stuck
- position all windows relevant to parent

Author: s-n-g

Changelog

@@ -1,3 +1,9 @@
+2023-04-01 s-n-g
+    * version 0.9.2.4
+    * do not crash when we have a small number of Groups
+    * get a minimum size so that we don't get stuck
+    * position all windows relevant to parent
+
 2023-04-01 s-n-g
     * version 0.9.2.3
     * fixing search function for Group Selection window (pressing

README.html

@@ -202,6 +202,12 @@ <h2 id="requirements">Requirements <span style="padding-left: 10px;"><sup style=
 <h2 id="changelog">Changelog <span style="padding-left: 10px;"><sup style="font-size: 50%"><a href="#" title="Go to top of the page">Top</a></sup></span></h2>
 <pre style="height: 200px;">
 
+2023-04-01 s-n-g
+    * version 0.9.2.4
+    * do not crash when we have a small number of Groups
+    * get a minimum size so that we don't get stuck
+    * position all windows relevant to parent
+
 2023-04-01 s-n-g
     * version 0.9.2.3
     * fixing search function for Group Selection window (pressing

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyradio"
-version = "0.9.2.3"
+version = "0.9.2.4"
 authors = [
   { name="Ben Dowling", email="[email protected]" },
   { name="Spiros Georgaras", email="[email protected]" },

pyradio/__init__.py

@@ -1,6 +1,6 @@
 " pyradio -- Console radio player. "
 
-version_info = (0, 9, 2, 3)
+version_info = (0, 9, 2, 4)
 
 # Set it to True if new stations have been
 # added to the package's stations.csv

pyradio/radio.py

@@ -2729,6 +2729,7 @@ def _show_group_help(self):
                  Down|,|k|,|PgDown    |Change Group Header selection.
                  g G              |Go to first / last Group Header.
                  H M L            |Go to top / middle / bottom of screen.
+                 / n N            |Perform search.
                  Space|, |Left|, |Enter
                  _________________|Select a Group Header.
                  Esc|,|q            |Cancel.
@@ -8391,13 +8392,13 @@ def keypress(self, char):
                             else:
                                 # logger.error('selection not in d')
                                 if len(d) == 1:
-                                    logger.error('x1 ind = {}'.format(ind))
                                     ind = d[0]
+                                    # logger.error('x1 ind = {}'.format(ind))
                                 else:
                                     if char == curses.ascii.EM:
                                         try:
                                             ind = [n for n in d if n < self.selection][-1]
-                                            logger.error('x2 ind = {}'.format(ind))
+                                            # logger.error('x2 ind = {}'.format(ind))
                                         except IndexError:
                                             ind = [n for n in d if n < self.number_of_items][0]
                                             # logger.error('x3 ind = {}'.format(ind))

pyradio/simple_curses_widgets.py

@@ -1855,23 +1855,37 @@ def _get_window(self):
             if self._maxX > X - 2 * self._outer_margin:
                 self._maxX = X - 2 * self._outer_margin
 
+            ''' make sure we have a big enough window '''
+            if self._maxY < 10:
+                self._maxY = 10
+            if self._maxX < 30:
+                self._maxX = 30
+
             aY, aX = self._parent.getbegyx()
             self._Y = aY + int((Y-self._maxY)/2)
-            self._X = int((X-self._maxX)/2)
+            self._X = aX + int((X-self._maxX)/2)
+
         else:
-            pass
+            aY, aX = self._parent.getbegyx()
 
         if self._maxY <= self._minY or \
-                self._maxX <= self._minX:
+                self._maxX <= self._minX or \
+                self._X < 2 or \
+                self._Y < 2:
             self._too_small = True
             aY, aX = self._parent.getbegyx()
             self._win = curses.newwin(
                 4, 13,
                 aY + int((Y-4)/2),
-                int((X-13)/2)
+                aX + int((X-13)/2)
             )
+            self._print_box()
         else:
             self._too_small = False
+            # logger.info('Y={0}, X={1}, maxY={2}, maxX={3}'.format(
+            #     self._Y, self._X,
+            #     self._maxY, self._maxX
+            # ))
             self._win = curses.newwin(
                 self._maxY, self._maxX,
                 self._Y, self._X
@@ -1968,14 +1982,23 @@ def show(self, parent=None):
             self.show()
             return
 
+        self._print_box_and_title()
+        self._refresh()
+
+    def _print_box_and_title(self):
+        self._print_box()
+        self._print_title()
+
+    def _print_box(self):
         self._win.bkgdset(' ', self._color_border)
         self._win.erase()
         self._win.box()
+
+    def _print_title(self):
         self._win.addstr(
             0, int((self._maxX-len(self._title))/2),
             self._title, self._color_title
         )
-        self._refresh()
 
     def _refresh(self):
         if len(self._items) == 0:
@@ -1991,6 +2014,9 @@ def _refresh(self):
             self._start_pos = 0
         elif self._start_pos > len(self._items) - 1 - self._body_maxY:
             self._start_pos = len(self._items) - self._body_maxY
+        ''' make sure we have a valid self._start_pos '''
+        if self._start_pos < 0:
+            self._start_pos = 0
         # logger.error('refresh (st={0}, sel={1})'.format(self._start_pos, self._selection))
         for i in range(0, self._body_maxY):
             item_id = i + self._start_pos