Unknown option --goto

[alanhe421]

Is there a mistake in the way it is used?

/usr/bin/code-server --auth none --goto /root/a.json@5:5

version info

code-server 4.8.3 977b853

[alanhe421]

@jsjoeio

Do you know the issue?

[code-asher]

Oh oops yeah looks like we made a typo in the release notes. No need for a new flag. I think in VS Code it is a separate flag which is why we got confused.

Yeah, this is how it works by design. The idea is that you spawn code-server as a system service that way it is always running in the background then -r will always try to connect to it and error if it is not up.

We could make -r spawn code-server if it has not spawned yet but it is kind of a weird scenario to be in because code-server is designed as a daemon and not a one-off process.

Also we plan on removing our code around this and calling Code's server CLI directly which has the same behavior so if we fix it now we would have to port those changes upstream somehow or maintain a patch.

Still, if the behavior is confusing enough maybe we make the change anyway.

[code-asher]

Whatever we do, we should really improve that error. ENOENT is not terribly helpful.

[alanhe421]

-r arg, from which version?

I test v4.7.1. it always refreshes when -r file, and column/row is not work.

it's different with v4.8.x.

[code-asher]

Yeah 4.8.0 added column/row support. I believe the code for this is the same in 4.7.1 and 4.8.0 (other than column/row). The logic goes like this:

1. Are we in an integrated terminal? If yes try to open in the existing instance.
2. Are there any arguments set other than --reuse-window or --new-window set? If yes spawn a new instance.
3. Does /tmp/vscode-ipc exist? If yes try opening in the instance listed in that file. If --reuse-window or --new-window are set do so unconditionally otherwise check first if the socket is actually in use and if not then spawn a new instance instead.
4. Otherwise spawn a new instance.

[code-asher]

I think we can simplify the logic and add some helpful output to make this easier to use.