Skip to content

Commit ebef18d

Browse files
committed
Fix connections sticking around indefinitely
For some reason it only affects the extension host socket (something to do with passing it via IPC?) but I changed both just to be sure. Fixes #1795.
1 parent a942531 commit ebef18d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: ci/dev/vscode.patch

+3-3
Original file line numberDiff line numberDiff line change
@@ -1811,7 +1811,7 @@ index 0000000000..1166835371
18111811
+}
18121812
diff --git a/src/vs/server/node/connection.ts b/src/vs/server/node/connection.ts
18131813
new file mode 100644
1814-
index 0000000000..23934687de
1814+
index 0000000000..36e80fb696
18151815
--- /dev/null
18161816
+++ b/src/vs/server/node/connection.ts
18171817
@@ -0,0 +1,157 @@
@@ -1878,7 +1878,7 @@ index 0000000000..23934687de
18781878
+ protected doDispose(): void {
18791879
+ this.protocol.sendDisconnect();
18801880
+ this.protocol.dispose();
1881-
+ this.protocol.getSocket().end();
1881+
+ this.protocol.getUnderlyingSocket().destroy();
18821882
+ }
18831883
+
18841884
+ protected doReconnect(socket: ISocket, buffer: VSBuffer): void {
@@ -1905,7 +1905,7 @@ index 0000000000..23934687de
19051905
+ if (this.process) {
19061906
+ this.process.kill();
19071907
+ }
1908-
+ this.protocol.getSocket().end();
1908+
+ this.protocol.getUnderlyingSocket().destroy();
19091909
+ }
19101910
+
19111911
+ protected doReconnect(socket: ISocket, buffer: VSBuffer): void {

0 commit comments

Comments
 (0)