only print process logs if it exited with a non-zero exit code

Author: hugodutka

cmd/server/server.go

@@ -2,6 +2,7 @@ package server
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"log/slog"
 	"net/http"
@@ -95,7 +96,11 @@ func runServer(ctx context.Context, logger *slog.Logger, argsToPass []string) er
 	go func() {
 		defer close(processExitCh)
 		if err := process.Wait(); err != nil {
-			processExitCh <- xerrors.Errorf("========\n%s\n========\n: %w", strings.TrimSpace(process.ReadScreen()), err)
+			if errors.Is(err, termexec.ErrNonZeroExitCode) {
+				processExitCh <- xerrors.Errorf("========\n%s\n========\n: %w", strings.TrimSpace(process.ReadScreen()), err)
+			} else {
+				processExitCh <- xerrors.Errorf("failed to wait for process: %w", err)
+			}
 		}
 		if err := srv.Stop(ctx); err != nil {
 			logger.Error("Failed to stop server", "error", err)

lib/termexec/termexec.go

@@ -111,14 +111,16 @@ func (p *Process) Close(logger *slog.Logger, timeout time.Duration) error {
 	return exitErr
 }
 
+var ErrNonZeroExitCode = xerrors.New("non-zero exit code")
+
 // Wait waits for the process to exit.
 func (p *Process) Wait() error {
 	state, err := p.execCmd.Process.Wait()
 	if err != nil {
 		return xerrors.Errorf("process exited with error: %w", err)
 	}
 	if state.ExitCode() != 0 {
-		return xerrors.Errorf("non-zero exit code: %d", state.ExitCode())
+		return ErrNonZeroExitCode
 	}
 	return nil
 }