Handle error when migrating configuration to >=0.3 format

Author: hlxid

nodecg-io-core/dashboard/crypto.ts

@@ -85,7 +85,10 @@ export async function setPassword(pw: string): Promise<boolean> {
             // Re-encrypt the configuration using our own derived key instead of the password.
             const newEncryptionKey = deriveEncryptionKey(pw, salt);
             const newEncryptionKeyArr = cryptoJS.enc.Hex.parse(newEncryptionKey);
-            reEncryptData(encryptedData.value, pw, newEncryptionKeyArr);
+            const res = reEncryptData(encryptedData.value, pw, newEncryptionKeyArr);
+            if (res.failed) {
+                throw new Error(`Failed to migrate config: ${res.errorMessage}`);
+            }
         }
 
         encryptedData.value.salt = salt;
@@ -127,7 +130,7 @@ export function isPasswordSet(): boolean {
 
 /**
  * Decrypts the passed data using the global encryptionKey variable and saves it into `ConfigData`.
- * Unsets the encryption key if its wrong and also forwards `undefined` to `ConfigData` if the encryption key is unset.
+ * Clears the encryption key if its wrong and also forwards `undefined` to `ConfigData` if the encryption key is unset.
  * @param data the data that should be decrypted.
  */
 function updateDecryptedData(data: EncryptedData): void {

nodecg-io-core/extension/persistenceManager.ts

@@ -70,7 +70,7 @@ export function decryptData(
 }
 
 /**
- * Encrypts the passed data objedt using the passed encryption key.
+ * Encrypts the passed data object using the passed encryption key.
  *
  * @param data the data that needs to be encrypted.
  * @param encryptionKey the encryption key that should be used to encrypt the data.
@@ -395,7 +395,10 @@ export class PersistenceManager {
                             // Re-encrypt the configuration using our own derived key instead of the password.
                             const newEncryptionKey = deriveEncryptionKey(password, salt);
                             const newEncryptionKeyArr = crypto.enc.Hex.parse(newEncryptionKey);
-                            reEncryptData(this.encryptedData.value, password, newEncryptionKeyArr);
+                            const res = reEncryptData(this.encryptedData.value, password, newEncryptionKeyArr);
+                            if (res.failed) {
+                                throw new Error(`Failed to migrate config: ${res.errorMessage}`);
+                            }
                         }
 
                         this.encryptedData.value.salt = salt;
@@ -407,7 +410,7 @@ export class PersistenceManager {
                     if (!loadResult.failed) {
                         this.nodecg.log.info("Automatic login successful.");
                     } else {
-                        throw loadResult.errorMessage;
+                        throw new Error(loadResult.errorMessage);
                     }
                 } catch (err) {
                     const logMesssage = `Failed to automatically login: ${err}`;