Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP message interfaces & factories (PSR-7/17) #3230

Open
MGatner opened this issue Jul 5, 2020 · 13 comments
Open

HTTP message interfaces & factories (PSR-7/17) #3230

MGatner opened this issue Jul 5, 2020 · 13 comments
Labels
enhancement PRs that improve existing functionalities
Milestone

Comments

@MGatner
Copy link
Member

MGatner commented Jul 5, 2020

At some point we should make sure we are implementing these compliance definitions:

@MGatner MGatner added the enhancement PRs that improve existing functionalities label Jul 5, 2020
@MGatner MGatner added this to the 4.1.0 milestone Jul 5, 2020
@agungsugiarto
Copy link
Contributor

@tada5hi
Copy link
Contributor

tada5hi commented Oct 15, 2020

What is the status about this @MGatner ? Are you working on it or should i do a pr? 😇✌️

@agungsugiarto
Copy link
Contributor

ping @MGatner

@MGatner
Copy link
Member Author

MGatner commented Oct 22, 2020

I'm not actively working on this. I started a couple weeks back and determined it should not be too much work.

@tada5hi
Copy link
Contributor

tada5hi commented Oct 26, 2020

so @MGatner you will catch it up later or should i just go ahead?

@MGatner
Copy link
Member Author

MGatner commented Oct 26, 2020

If you can implement it then please go ahead and do so! I will not be working on this for a while.

@tada5hi
Copy link
Contributor

tada5hi commented Oct 28, 2020

@MGatner thx, i think so 😄 . I will try to keep backwards compatible.

@MGatner
Copy link
Member Author

MGatner commented Nov 22, 2020

@tada5hi No pressure but I'm gathering some info for 4.1 - do you think this will be done this week?

@asrofie
Copy link

asrofie commented Jun 8, 2021

Hi Team,
Anyone still working on this ?
If no one, I want to try handle it.

@MGatner
Copy link
Member Author

MGatner commented Jun 8, 2021

Nobody is working on it actively, please do! Familiarize yourself with the existing PRs and the conversations on those. The tricky part, if I recall, is that our version of Message has getHeader() and getHeaders() which do not comply with PSR-7 (because they return Header). However since then I think we figured out that we could make Header stringable and still comply.

Regardless pay attention that no breaking changes are made, and leverage those HTTP Integration tests (so you shouldn't have to write many!).

@MGatner
Copy link
Member Author

MGatner commented Jun 8, 2021

Also, if you determine that this won't fit in the core framework you can compare what I did with PSR Cache and Simple Cache: https://github.com/codeigniter4/cache

We could definitely add HTTP as a separate module

@asrofie
Copy link

asrofie commented Jun 8, 2021

Oke, I will create implementation first.

@kenjis kenjis changed the title HTTP message interfaces & factories HTTP message interfaces & factories (PSR-7/17) Dec 8, 2021
@kenjis kenjis mentioned this issue Dec 8, 2021
5 tasks
@paulbalandan paulbalandan modified the milestones: 4.1.0, 4.4 Nov 4, 2022
@kenjis
Copy link
Member

kenjis commented Dec 7, 2022

Ref, #6910 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

No branches or pull requests

6 participants