fix: close() should return false if releaseLock() failed

kenjis · kenjis · commit 63beda25040e · 2024-02-23T15:34:36.000+09:00
The return value (usually true on success, false on failure) https://www.php.net/manual/en/sessionhandlerinterface.close.php#refsect1-sessionhandlerinterface.close-returnvalues
diff --git a/system/Session/Handlers/RedisHandler.php b/system/Session/Handlers/RedisHandler.php
@@ -231,7 +231,9 @@ public function close(): bool
 
                 if (($pingReply === true) || ($pingReply === '+PONG')) {
                     if (isset($this->lockKey)) {
-                        $this->releaseLock();
+                        if (! $this->releaseLock()) {
+                            return false;
+                        }
                     }
 
                     if (! $this->redis->close()) {

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,9 @@ public function close(): bool`
`231`	`231`
`232`	`232`	`if (($pingReply === true) \|\| ($pingReply === '+PONG')) {`
`233`	`233`	`if (isset($this->lockKey)) {`
`234`		`- $this->releaseLock();`
	`234`	`+ if (! $this->releaseLock()) {`
	`235`	`+ return false;`
	`236`	`+ }`
`235`	`237`	`}`
`236`	`238`
`237`	`239`	`if (! $this->redis->close()) {`