Skip to content

Commit dae3c07

Browse files
committed
Include JDK 24ea in CI
1 parent 8d5b80c commit dae3c07

File tree

4 files changed

+32
-26
lines changed

4 files changed

+32
-26
lines changed

.github/workflows/maven.yml

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ jobs:
2525
uses: codehaus-plexus/.github/.github/workflows/maven.yml@master
2626
with:
2727
matrix-exclude: '[ {"jdk": "8"}, {"jdk": "11"}, {"jdk": "23", distribution: "microsoft" } ]'
28+
matrix-include: >
29+
[
30+
{"jdk": "24-ea", "os": "ubuntu-latest", distribution: "temurin" }
31+
]
2832
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica", "corretto"]'
2933
maven_args: 'verify javadoc:javadoc -e -B -V -fae'
3034

plexus-compilers/plexus-compiler-javac-errorprone/src/test/java/org/codehaus/plexus/compiler/javac/JavacErrorProneCompilerTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ protected int expectedWarnings() {
2424
|| javaVersion.contains("22")
2525
|| javaVersion.contains("23")) {
2626
return 5;
27+
} else if (javaVersion.contains("24")) {
28+
return 4;
2729
}
2830
return 2;
2931
}

plexus-compilers/plexus-compiler-javac/src/test/java/org/codehaus/plexus/compiler/javac/AbstractJavacCompilerTest.java

+22-25
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ protected int expectedErrors() {
7070
|| javaVersion.contains("20")
7171
|| javaVersion.contains("21")
7272
|| javaVersion.contains("22")
73-
|| javaVersion.contains("23")) {
73+
|| javaVersion.contains("23")
74+
|| javaVersion.contains("24")) {
7475
return 5;
7576
}
7677
// javac output changed for misspelled modifiers starting in 1.6...they now generate 2 errors per occurrence,
@@ -96,7 +97,8 @@ protected int expectedWarnings() {
9697
|| javaVersion.contains("20")
9798
|| javaVersion.contains("21")
9899
|| javaVersion.contains("22")
99-
|| javaVersion.contains("23")) {
100+
|| javaVersion.contains("23")
101+
|| javaVersion.contains("24")) {
100102
return 1;
101103
}
102104
if (javaVersion.contains("1.8")) {
@@ -151,6 +153,9 @@ public String getTargetVersion() {
151153
if (javaVersion.contains("23")) {
152154
return "23";
153155
}
156+
if (javaVersion.contains("24")) {
157+
return "24";
158+
}
154159
return super.getTargetVersion();
155160
}
156161

@@ -159,39 +164,30 @@ public String getSourceVersion() {
159164
String javaVersion = getJavaVersion();
160165
if (javaVersion.contains("9.0")) {
161166
return "1.7";
162-
}
163-
if (javaVersion.contains("11")) {
167+
} else if (javaVersion.contains("11")) {
164168
return "11";
165-
}
166-
if (javaVersion.contains("14")) {
169+
} else if (javaVersion.contains("14")) {
167170
return "14";
168-
}
169-
if (javaVersion.contains("15")) {
171+
} else if (javaVersion.contains("15")) {
170172
return "15";
171-
}
172-
if (javaVersion.contains("16")) {
173+
} else if (javaVersion.contains("16")) {
173174
return "16";
174-
}
175-
if (javaVersion.contains("17")) {
175+
} else if (javaVersion.contains("17")) {
176176
return "17";
177-
}
178-
if (javaVersion.contains("18")) {
177+
} else if (javaVersion.contains("18")) {
179178
return "18";
180-
}
181-
if (javaVersion.contains("19")) {
179+
} else if (javaVersion.contains("19")) {
182180
return "19";
183-
}
184-
if (javaVersion.contains("20")) {
181+
} else if (javaVersion.contains("20")) {
185182
return "20";
186-
}
187-
if (javaVersion.contains("21")) {
183+
} else if (javaVersion.contains("21")) {
188184
return "21";
189-
}
190-
if (javaVersion.contains("22")) {
185+
} else if (javaVersion.contains("22")) {
191186
return "22";
192-
}
193-
if (javaVersion.contains("23")) {
187+
} else if (javaVersion.contains("23")) {
194188
return "23";
189+
} else if (javaVersion.contains("24")) {
190+
return "24";
195191
}
196192
return super.getTargetVersion();
197193
}
@@ -210,7 +206,8 @@ protected Collection<String> expectedOutputFiles() {
210206
|| javaVersion.contains("20")
211207
|| javaVersion.contains("21")
212208
|| javaVersion.contains("22")
213-
|| javaVersion.contains("23")) {
209+
|| javaVersion.contains("23")
210+
|| javaVersion.contains("24")) {
214211
return Arrays.asList(
215212
"org/codehaus/foo/Deprecation.class",
216213
"org/codehaus/foo/ExternalDeps.class",

plexus-compilers/plexus-compiler-javac/src/test/java/org/codehaus/plexus/compiler/javac/JavaxToolsCompilerTest.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,10 @@ public class JavaxToolsCompilerTest extends AbstractJavacCompilerTest {
2727
@Override
2828
protected int expectedWarnings() {
2929
String javaVersion = getJavaVersion();
30-
if (javaVersion.contains("21") || javaVersion.contains("22") || javaVersion.contains("23")) {
30+
if (javaVersion.contains("21")
31+
|| javaVersion.contains("22")
32+
|| javaVersion.contains("23")
33+
|| javaVersion.contains("24")) {
3134
return 1;
3235
} else {
3336
return super.expectedWarnings();

0 commit comments

Comments
 (0)