Skip to content

Commit d5d8f1a

Browse files
committed
Switch to SISU annotations and plugin
1 parent 0d01dc2 commit d5d8f1a

File tree

16 files changed

+83
-44
lines changed

16 files changed

+83
-44
lines changed

plexus-compiler-manager/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<artifactId>plexus-compiler-api</artifactId>
1919
</dependency>
2020
<dependency>
21-
<groupId>org.codehaus.plexus</groupId>
22-
<artifactId>plexus-component-annotations</artifactId>
21+
<groupId>javax.inject</groupId>
22+
<artifactId>javax.inject</artifactId>
2323
</dependency>
2424
<dependency>
2525
<groupId>org.junit.jupiter</groupId>

plexus-compiler-manager/src/main/java/org/codehaus/plexus/compiler/manager/DefaultCompilerManager.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,19 @@
2525
*/
2626

2727
import org.codehaus.plexus.compiler.Compiler;
28-
import org.codehaus.plexus.component.annotations.Component;
29-
import org.codehaus.plexus.component.annotations.Requirement;
3028

29+
import javax.inject.Inject;
30+
import javax.inject.Named;
3131
import java.util.Map;
3232

3333
/**
3434
* @author <a href="mailto:[email protected]">Trygve Laugst&oslash;l</a>
3535
*/
36-
@Component( role = CompilerManager.class )
36+
@Named
3737
public class DefaultCompilerManager
3838
implements CompilerManager
3939
{
40-
@Requirement
40+
@Inject
4141
private Map<String, Compiler> compilers;
4242

4343
// ----------------------------------------------------------------------

plexus-compilers/plexus-compiler-aspectj/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
<dependencies>
2121
<dependency>
22-
<groupId>org.codehaus.plexus</groupId>
23-
<artifactId>plexus-component-annotations</artifactId>
22+
<groupId>javax.inject</groupId>
23+
<artifactId>javax.inject</artifactId>
2424
</dependency>
2525
<dependency>
2626
<groupId>org.aspectj</groupId>

plexus-compilers/plexus-compiler-aspectj/src/main/java/org/codehaus/plexus/compiler/ajc/AspectJCompiler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
import org.aspectj.org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
1111
import org.aspectj.tools.ajc.Main;
1212
import org.codehaus.plexus.compiler.AbstractCompiler;
13-
import org.codehaus.plexus.compiler.Compiler;
1413
import org.codehaus.plexus.compiler.CompilerConfiguration;
1514
import org.codehaus.plexus.compiler.CompilerException;
1615
import org.codehaus.plexus.compiler.CompilerMessage;
1716
import org.codehaus.plexus.compiler.CompilerOutputStyle;
1817
import org.codehaus.plexus.compiler.CompilerResult;
19-
import org.codehaus.plexus.component.annotations.Component;
2018
import org.codehaus.plexus.util.DirectoryScanner;
2119

20+
import javax.inject.Named;
21+
import javax.inject.Singleton;
2222
import java.io.File;
2323
import java.io.IOException;
2424
import java.net.MalformedURLException;
@@ -287,7 +287,7 @@
287287
*
288288
* @author <a href="mailto:[email protected]">Jason van Zyl</a>
289289
*/
290-
@Component( role = Compiler.class, hint = "aspectj")
290+
@Named("aspectj")
291291
public class AspectJCompiler
292292
extends AbstractCompiler
293293
{

plexus-compilers/plexus-compiler-csharp/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
<dependencies>
1717
<dependency>
18-
<groupId>org.codehaus.plexus</groupId>
19-
<artifactId>plexus-component-annotations</artifactId>
18+
<groupId>javax.inject</groupId>
19+
<artifactId>javax.inject</artifactId>
2020
</dependency>
2121
<dependency>
2222
<groupId>org.codehaus.plexus</groupId>

plexus-compilers/plexus-compiler-csharp/src/main/java/org/codehaus/plexus/compiler/csharp/CSharpCompiler.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
*/
1818

1919
import org.codehaus.plexus.compiler.AbstractCompiler;
20-
import org.codehaus.plexus.compiler.Compiler;
2120
import org.codehaus.plexus.compiler.CompilerConfiguration;
2221
import org.codehaus.plexus.compiler.CompilerException;
2322
import org.codehaus.plexus.compiler.CompilerMessage;
2423
import org.codehaus.plexus.compiler.CompilerOutputStyle;
2524
import org.codehaus.plexus.compiler.CompilerResult;
26-
import org.codehaus.plexus.component.annotations.Component;
2725
import org.codehaus.plexus.util.DirectoryScanner;
2826
import org.codehaus.plexus.util.IOUtil;
2927
import org.codehaus.plexus.util.Os;
@@ -34,6 +32,7 @@
3432
import org.codehaus.plexus.util.cli.StreamConsumer;
3533
import org.codehaus.plexus.util.cli.WriterStreamConsumer;
3634

35+
import javax.inject.Named;
3736
import java.io.BufferedReader;
3837
import java.io.File;
3938
import java.io.FileWriter;
@@ -57,7 +56,7 @@
5756
* @author <a href="mailto:[email protected]">Matthew Pocock</a>
5857
* @author <a href="mailto:[email protected]">Chris Stevenson</a>
5958
*/
60-
@Component( role = Compiler.class, hint = "csharp" )
59+
@Named( "csharp" )
6160
public class CSharpCompiler
6261
extends AbstractCompiler
6362
{

plexus-compilers/plexus-compiler-eclipse/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
<version>3.33.0</version>
3333
</dependency>
3434
<dependency>
35-
<groupId>org.codehaus.plexus</groupId>
36-
<artifactId>plexus-component-annotations</artifactId>
35+
<groupId>javax.inject</groupId>
36+
<artifactId>javax.inject</artifactId>
3737
</dependency>
3838
<dependency>
3939
<groupId>org.junit.jupiter</groupId>

plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* SOFTWARE.
2525
*/
2626

27+
import javax.inject.Named;
28+
import javax.inject.Singleton;
2729
import javax.tools.Diagnostic;
2830
import javax.tools.DiagnosticListener;
2931
import javax.tools.JavaCompiler;
@@ -44,21 +46,20 @@
4446
import java.util.Map.Entry;
4547
import java.util.ServiceLoader;
4648
import org.codehaus.plexus.compiler.AbstractCompiler;
47-
import org.codehaus.plexus.compiler.Compiler;
4849
import org.codehaus.plexus.compiler.CompilerConfiguration;
4950
import org.codehaus.plexus.compiler.CompilerException;
5051
import org.codehaus.plexus.compiler.CompilerMessage;
5152
import org.codehaus.plexus.compiler.CompilerOutputStyle;
5253
import org.codehaus.plexus.compiler.CompilerResult;
53-
import org.codehaus.plexus.component.annotations.Component;
5454
import org.codehaus.plexus.util.StringUtils;
5555
import org.eclipse.jdt.core.compiler.CompilationProgress;
5656
import org.eclipse.jdt.core.compiler.batch.BatchCompiler;
5757

5858
/**
5959
*
6060
*/
61-
@Component( role = Compiler.class, hint = "eclipse" )
61+
@Named( "eclipse" )
62+
@Singleton
6263
public class EclipseJavaCompiler
6364
extends AbstractCompiler
6465
{

plexus-compilers/plexus-compiler-j2objc/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<artifactId>plexus-utils</artifactId>
2020
</dependency>
2121
<dependency>
22-
<groupId>org.codehaus.plexus</groupId>
23-
<artifactId>plexus-component-annotations</artifactId>
22+
<groupId>javax.inject</groupId>
23+
<artifactId>javax.inject</artifactId>
2424
</dependency>
2525
<dependency>
2626
<groupId>org.junit.jupiter</groupId>

plexus-compilers/plexus-compiler-j2objc/src/main/java/org/codehaus/plexus/compiler/j2objc/J2ObjCCompiler.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,20 @@
1717
*/
1818

1919
import org.codehaus.plexus.compiler.AbstractCompiler;
20-
import org.codehaus.plexus.compiler.Compiler;
2120
import org.codehaus.plexus.compiler.CompilerConfiguration;
2221
import org.codehaus.plexus.compiler.CompilerException;
2322
import org.codehaus.plexus.compiler.CompilerMessage;
2423
import org.codehaus.plexus.compiler.CompilerMessage.Kind;
2524
import org.codehaus.plexus.compiler.CompilerOutputStyle;
2625
import org.codehaus.plexus.compiler.CompilerResult;
27-
import org.codehaus.plexus.component.annotations.Component;
2826
import org.codehaus.plexus.util.StringUtils;
2927
import org.codehaus.plexus.util.cli.CommandLineException;
3028
import org.codehaus.plexus.util.cli.CommandLineUtils;
3129
import org.codehaus.plexus.util.cli.Commandline;
3230
import org.codehaus.plexus.util.cli.StreamConsumer;
3331
import org.codehaus.plexus.util.cli.WriterStreamConsumer;
3432

33+
import javax.inject.Named;
3534
import java.io.BufferedReader;
3635
import java.io.File;
3736
import java.io.IOException;
@@ -51,7 +50,7 @@
5150
* Ma&icirc;tre</a>
5251
*
5352
*/
54-
@Component( role = Compiler.class, hint = "j2objc")
53+
@Named( "j2objc" )
5554
public class J2ObjCCompiler
5655
extends AbstractCompiler
5756
{

plexus-compilers/plexus-compiler-javac-errorprone/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
<version>${errorprone.version}</version>
3737
</dependency>
3838
<dependency>
39-
<groupId>org.codehaus.plexus</groupId>
40-
<artifactId>plexus-component-annotations</artifactId>
39+
<groupId>javax.inject</groupId>
40+
<artifactId>javax.inject</artifactId>
4141
</dependency>
4242
</dependencies>
4343

plexus-compilers/plexus-compiler-javac-errorprone/src/main/java/org/codehaus/plexus/compiler/javac/errorprone/JavacCompilerWithErrorProne.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,15 @@
1818

1919
import com.google.errorprone.ErrorProneJavaCompiler;
2020

21-
import org.codehaus.plexus.compiler.Compiler;
2221
import org.codehaus.plexus.compiler.CompilerConfiguration;
2322
import org.codehaus.plexus.compiler.CompilerException;
2423
import org.codehaus.plexus.compiler.CompilerMessage;
2524
import org.codehaus.plexus.compiler.CompilerResult;
2625
import org.codehaus.plexus.compiler.javac.InProcessCompiler;
2726
import org.codehaus.plexus.compiler.javac.JavacCompiler;
2827
import org.codehaus.plexus.compiler.javac.JavaxToolsCompiler;
29-
import org.codehaus.plexus.component.annotations.Component;
3028

29+
import javax.inject.Named;
3130
import javax.tools.JavaCompiler;
3231

3332
import java.net.MalformedURLException;
@@ -40,7 +39,7 @@
4039
*
4140
* @author <a href="mailto:[email protected]">Alex Eagle</a>
4241
*/
43-
@Component( role = Compiler.class, hint = "javac-with-errorprone")
42+
@Named("javac-with-errorprone")
4443
public class JavacCompilerWithErrorProne
4544
extends JavacCompiler
4645
{

plexus-compilers/plexus-compiler-javac/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<artifactId>plexus-utils</artifactId>
2020
</dependency>
2121
<dependency>
22-
<groupId>org.codehaus.plexus</groupId>
23-
<artifactId>plexus-component-annotations</artifactId>
22+
<groupId>javax.inject</groupId>
23+
<artifactId>javax.inject</artifactId>
2424
</dependency>
2525
<dependency>
2626
<groupId>org.junit.jupiter</groupId>

plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -63,29 +63,31 @@
6363
import java.util.concurrent.CopyOnWriteArrayList;
6464

6565
import org.codehaus.plexus.compiler.AbstractCompiler;
66-
import org.codehaus.plexus.compiler.Compiler;
6766
import org.codehaus.plexus.compiler.CompilerConfiguration;
6867
import org.codehaus.plexus.compiler.CompilerException;
6968
import org.codehaus.plexus.compiler.CompilerMessage;
7069
import org.codehaus.plexus.compiler.CompilerOutputStyle;
7170
import org.codehaus.plexus.compiler.CompilerResult;
72-
import org.codehaus.plexus.component.annotations.Component;
73-
import org.codehaus.plexus.component.annotations.Requirement;
7471
import org.codehaus.plexus.util.FileUtils;
7572
import org.codehaus.plexus.util.Os;
7673
import org.codehaus.plexus.util.StringUtils;
7774
import org.codehaus.plexus.util.cli.CommandLineException;
7875
import org.codehaus.plexus.util.cli.CommandLineUtils;
7976
import org.codehaus.plexus.util.cli.Commandline;
8077

78+
import javax.inject.Inject;
79+
import javax.inject.Named;
80+
import javax.inject.Singleton;
81+
8182
/**
8283
* @author <a href="mailto:[email protected]">Trygve Laugst&oslash;l</a>
8384
* @author <a href="mailto:[email protected]">Matthew Pocock</a>
8485
* @author <a href="mailto:[email protected]">J&ouml;rg Wa&szlig;mer</a>
8586
* @author Others
8687
*
8788
*/
88-
@Component( role = Compiler.class, hint = "javac" )
89+
@Named("javac")
90+
@Singleton
8991
public class JavacCompiler
9092
extends AbstractCompiler
9193
{
@@ -107,7 +109,7 @@ public class JavacCompiler
107109

108110
private final List<Class<?>> javaccClasses = new CopyOnWriteArrayList<>();
109111

110-
@Requirement
112+
@Inject
111113
private InProcessCompiler inProcessCompiler;
112114

113115
// ----------------------------------------------------------------------

plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavaxToolsCompiler.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
import org.codehaus.plexus.compiler.CompilerMessage;
2323
import org.codehaus.plexus.compiler.CompilerException;
2424
import org.codehaus.plexus.compiler.CompilerResult;
25-
import org.codehaus.plexus.component.annotations.Component;
2625
import org.slf4j.Logger;
2726
import org.slf4j.LoggerFactory;
2827

28+
import javax.inject.Named;
2929
import javax.tools.Diagnostic;
3030
import javax.tools.DiagnosticCollector;
3131
import javax.tools.JavaCompiler;
@@ -45,7 +45,7 @@
4545
* @author <a href="mailto:[email protected]">David M. Lloyd</a>
4646
* @since 2.0
4747
*/
48-
@Component( role = InProcessCompiler.class )
48+
@Named
4949
public class JavaxToolsCompiler implements InProcessCompiler
5050
{
5151
private final Logger log = LoggerFactory.getLogger( getClass() );

pom.xml

+43-4
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,11 @@
8888
<artifactId>plexus-component-annotations</artifactId>
8989
<version>2.1.1</version>
9090
</dependency>
91+
<dependency>
92+
<groupId>javax.inject</groupId>
93+
<artifactId>javax.inject</artifactId>
94+
<version>1</version>
95+
</dependency>
9196
<dependency>
9297
<groupId>org.junit</groupId>
9398
<artifactId>junit-bom</artifactId>
@@ -100,6 +105,16 @@
100105
<artifactId>plexus-testing</artifactId>
101106
<version>1.1.0</version>
102107
</dependency>
108+
<dependency>
109+
<groupId>org.eclipse.sisu</groupId>
110+
<artifactId>org.eclipse.sisu.plexus</artifactId>
111+
<version>0.9.0.M2</version>
112+
</dependency>
113+
<dependency>
114+
<groupId>org.eclipse.sisu</groupId>
115+
<artifactId>org.eclipse.sisu.inject</artifactId>
116+
<version>0.9.0.M2</version>
117+
</dependency>
103118
<dependency>
104119
<groupId>org.hamcrest</groupId>
105120
<artifactId>hamcrest</artifactId>
@@ -123,6 +138,9 @@
123138
<groupId>org.apache.maven.plugins</groupId>
124139
<artifactId>maven-compiler-plugin</artifactId>
125140
<version>${maven.compiler.version}</version>
141+
<configuration>
142+
<proc>none</proc>
143+
</configuration>
126144
</plugin>
127145
<plugin>
128146
<groupId>org.apache.maven.plugins</groupId>
@@ -154,10 +172,16 @@
154172
<artifactId>plexus-component-metadata</artifactId>
155173
<executions>
156174
<execution>
157-
<goals>
158-
<goal>generate-metadata</goal>
159-
<goal>merge-metadata</goal>
160-
</goals>
175+
<id>process-classes</id>
176+
<phase>none</phase>
177+
</execution>
178+
<execution>
179+
<id>process-test-classes</id>
180+
<phase>none</phase>
181+
</execution>
182+
<execution>
183+
<id>default</id>
184+
<phase>none</phase>
161185
</execution>
162186
</executions>
163187
</plugin>
@@ -205,6 +229,21 @@
205229
</executions>
206230
</plugin>
207231

232+
<plugin>
233+
<groupId>org.eclipse.sisu</groupId>
234+
<artifactId>sisu-maven-plugin</artifactId>
235+
<version>0.9.0.M2</version>
236+
<executions>
237+
<execution>
238+
<id>index-project</id>
239+
<goals>
240+
<goal>main-index</goal>
241+
<goal>test-index</goal>
242+
</goals>
243+
</execution>
244+
</executions>
245+
</plugin>
246+
208247
</plugins>
209248
</build>
210249

0 commit comments

Comments
 (0)