Merge pull request #404 from celinegilet/main

garronej · web-flow · commit b97bc2361fe1 · 2025-04-15T11:43:54.000+02:00
fix(SelectNext): No generation of aria-describedby referencing a non-existant id in the case of a default state (#402)
diff --git a/src/SelectNext.tsx b/src/SelectNext.tsx
@@ -174,9 +174,11 @@ function NonMemoizedNonForwardedSelect<T extends SelectProps.Option[]>(
                 className={cx(fr.cx("fr-select"), nativeSelectProps.className)}
                 id={selectId}
                 aria-describedby={
-                    nativeSelectProps["aria-describedby"] !== undefined
+                    state !== "default" && nativeSelectProps["aria-describedby"] !== undefined
                         ? `${stateDescriptionId} ${nativeSelectProps["aria-describedby"]}`
-                        : stateDescriptionId
+                        : state !== "default"
+                        ? stateDescriptionId
+                        : undefined
                 }
                 disabled={disabled}
             >

Original file line number	Diff line number	Diff line change
`@@ -174,9 +174,11 @@ function NonMemoizedNonForwardedSelect<T extends SelectProps.Option[]>(`
`174`	`174`	`className={cx(fr.cx("fr-select"), nativeSelectProps.className)}`
`175`	`175`	`id={selectId}`
`176`	`176`	`aria-describedby={`
`177`		`- nativeSelectProps["aria-describedby"] !== undefined`
	`177`	`+ state !== "default" && nativeSelectProps["aria-describedby"] !== undefined`
`178`	`178`	? `${stateDescriptionId} ${nativeSelectProps["aria-describedby"]}`
`179`		`- : stateDescriptionId`
	`179`	`+ : state !== "default"`
	`180`	`+ ? stateDescriptionId`
	`181`	`+ : undefined`
`180`	`182`	`}`
`181`	`183`	`disabled={disabled}`
`182`	`184`	`>`