continue execution when task failed (#97)

SAAS-5961

Author: oren-codefresh

jobs/TaskPullerJob/TaskPuller.job.js

@@ -58,7 +58,9 @@ class TaskPullerJob extends Base {
 				taskUid: new Chance().guid()
 			});
 			const task = new Task(this.codefreshAPI, this.kubernetesAPI, logger);
-			return task.exec(taskSpec);
+			return task.exec(taskSpec).catch((err) => {
+				this.logger.info(err);
+			});
 		};
 	}
 

jobs/TaskPullerJob/__tests__/TaskPuller.job.spec.js

@@ -41,7 +41,7 @@ describe('TaskPullerJob unit tests', () => {
 	it('Should map all results to tasks by types and execute them', () => {
 		CreatePodTask.mockImplementationOnce(() => {
 			return {
-				exec: jest.fn(() => {
+				exec: jest.fn(async () => {
 					return {
 						status: 'ok'
 					};
@@ -86,6 +86,41 @@ describe('TaskPullerJob unit tests', () => {
 		return expect(task.exec()).resolves.toEqual([]);
 	});
 
+	it('Should not fail when a task failed', () => {
+		const tasks = [
+			{
+				type: 'DeletePod',
+			},
+			{
+				type: 'CreatePod',
+			}
+		];
+		DeletePodTask.mockImplementationOnce(() => ({
+			exec: jest.fn(async () => Promise.reject('error'))	
+		}));
+		CreatePodTask.mockImplementationOnce(() => ({
+			exec: jest.fn(async () => Promise.resolve('value'))	
+		}));
+		const logger = createLogger();
+		const task = new TaskPullerJob({
+			pullTasks: jest.fn().mockResolvedValue(tasks),
+		}, _.noop(), logger);
+		return expect(task.exec()).resolves.toEqual(['value', undefined]);
+	});
+
+	it('Should not fail when task failed', () => {
+		const tasks = [
+			{
+				prop: 'a'
+			},
+		];
+		const logger = createLogger();
+		const task = new TaskPullerJob({
+			pullTasks: jest.fn().mockResolvedValue(tasks),
+		}, _.noop(), logger);
+		return expect(task.exec()).resolves.toEqual([]);
+	});
+
 	it('Should always execute and resolve the HIGH priority task first', async () => {
 		const tasks = [
 			{

package.json

@@ -1,6 +1,6 @@
 {
   "name": "venona",
-  "version": "0.30.3",
+  "version": "0.30.4",
   "description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
   "main": "index.js",
   "scripts": {

venonactl/VERSION

@@ -1 +1 @@
-0.30.3
+0.30.4