Skip to content

Commit 7faf2d1

Browse files
author
Oleg Sucharevich
committed
fix bug, deafult storage class not passed after refactor
1 parent b16f719 commit 7faf2d1

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "venona",
3-
"version": "0.17.0",
3+
"version": "0.17.1",
44
"description": "Codefresh agent to run on Codefresh's runtime environment and execute pipeline",
55
"main": "index.js",
66
"scripts": {

venonactl/cmd/install.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,18 @@ var installCmd = &cobra.Command{
5959
extendStoreWithKubeClient()
6060

6161
builder := plugins.NewBuilder()
62+
isDefault := isUsingDefaultStorageClass(installCmdOptions.storageClass)
63+
6264
builderInstallOpt := &plugins.InstallOptions{
6365
CodefreshHost: s.CodefreshAPI.Host,
6466
CodefreshToken: s.CodefreshAPI.Token,
6567
ClusterNamespace: s.KubernetesAPI.Namespace,
6668
MarkAsDefault: installCmdOptions.setDefaultRuntime,
6769
StorageClass: installCmdOptions.storageClass,
68-
IsDefaultStorageClass: isUsingDefaultStorageClass(installCmdOptions.storageClass),
70+
IsDefaultStorageClass: isDefault,
71+
}
72+
if isDefault {
73+
builderInstallOpt.StorageClass = plugins.DefaultStorageClassNamePrefix
6974
}
7075

7176
if installCmdOptions.kube.context == "" {
@@ -114,7 +119,7 @@ var installCmd = &cobra.Command{
114119
Add(plugins.RuntimeEnvironmentPluginType).
115120
Add(plugins.VenonaPluginType)
116121
}
117-
if isUsingDefaultStorageClass(installCmdOptions.storageClass) {
122+
if isDefault {
118123
builder.Add(plugins.VolumeProvisionerPluginType)
119124
} else {
120125
logrus.Info("Non default StorageClass is set, skipping installation of volume provisioner")

0 commit comments

Comments
 (0)