handle errors from requests

Author: Oleg Sucharevich

VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

cmd/create_token.go

@@ -28,7 +28,8 @@ var createTokenCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		client := viper.Get("codefresh")
 		codefreshClient := utils.CastToCodefreshOrDie(client)
-		token := codefreshClient.GenerateToken("TestToken", "hybrid/codefresh-re")
+		token, err := codefreshClient.GenerateToken("TestToken", "hybrid/codefresh-re")
+		internal.DieOnError(err)
 		table := internal.CreateTable()
 		table.SetHeader([]string{"name", "token"})
 		table.Append([]string{token.Name, token.Value})

cmd/get_pipeline.go

@@ -37,7 +37,8 @@ var getPipelineCmd = &cobra.Command{
 		table := internal.CreateTable()
 		table.SetHeader([]string{"Pipeline Name", "Created At", "Updated At"})
 		table.Append([]string{"", "", ""})
-		pipelines := codefreshClient.GetPipelines()
+		pipelines, err := codefreshClient.GetPipelines()
+		internal.DieOnError(err)
 		for _, p := range pipelines {
 			table.Append([]string{
 				p.Metadata.Name,

cmd/get_tokens.go

@@ -34,7 +34,8 @@ var getTokensCmd = &cobra.Command{
 		table := internal.CreateTable()
 		table.SetHeader([]string{"Created", "ID", "Name", "Reference Subject", "Reference Type", "Token"})
 		table.Append([]string{"", "", ""})
-		tokens := codefreshClient.GetTokens()
+		tokens, err := codefreshClient.GetTokens()
+		internal.DieOnError(err)
 		for _, t := range tokens {
 			table.Append([]string{
 				humanize.Time(t.Created),

cmd/run_pipeline.go

@@ -18,6 +18,7 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/codefresh-io/go-sdk/internal"
 	"github.com/codefresh-io/go-sdk/pkg/utils"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -39,7 +40,8 @@ var runPipelineCmd = &cobra.Command{
 		client := viper.Get("codefresh")
 		codefreshClient := utils.CastToCodefreshOrDie(client)
 		for _, name := range args {
-			build := codefreshClient.RunPipeline(name)
+			build, err := codefreshClient.RunPipeline(name)
+			internal.DieOnError(err)
 			fmt.Printf("Pipeline started with ID: %s\n", build)
 		}
 	},

internal/error_handler.go

@@ -0,0 +1,13 @@
+package internal
+
+import (
+	"fmt"
+	"os"
+)
+
+func DieOnError(err error) {
+	if err != nil {
+		fmt.Println(err)
+		os.Exit(1)
+	}
+}

pkg/codefresh/codefresh.go

@@ -1,14 +1,16 @@
 package codefresh
 
 import (
+	"fmt"
+
 	"gopkg.in/h2non/gentleman.v2"
 	"gopkg.in/h2non/gentleman.v2/plugins/body"
 	"gopkg.in/h2non/gentleman.v2/plugins/query"
 )
 
 type (
 	Codefresh interface {
-		requestAPI(*requestOptions) *gentleman.Response
+		requestAPI(*requestOptions) (*gentleman.Response, error)
 		ITokenAPI
 		IPipelineAPI
 	}
@@ -23,7 +25,7 @@ func New(opt *ClietOptions) Codefresh {
 	}
 }
 
-func (c *codefresh) requestAPI(opt *requestOptions) *gentleman.Response {
+func (c *codefresh) requestAPI(opt *requestOptions) (*gentleman.Response, error) {
 	req := c.client.Request()
 	req.Path(opt.path)
 	req.Method(opt.method)
@@ -37,5 +39,8 @@ func (c *codefresh) requestAPI(opt *requestOptions) *gentleman.Response {
 		}
 	}
 	res, _ := req.Send()
-	return res
+	if res.StatusCode > 400 {
+		return res, fmt.Errorf("Error occured during API invocation\nError: %s", res.String())
+	}
+	return res, nil
 }

pkg/codefresh/pipeline.go

@@ -9,8 +9,8 @@ import (
 type (
 	// IPipelineAPI declers Codefresh pipeline API
 	IPipelineAPI interface {
-		GetPipelines() []*Pipeline
-		RunPipeline(string) string
+		GetPipelines() ([]*Pipeline, error)
+		RunPipeline(string) (string, error)
 	}
 
 	PipelineMetadata struct {
@@ -61,20 +61,20 @@ type (
 )
 
 // GetPipelines - returns pipelines from API
-func (c *codefresh) GetPipelines() []*Pipeline {
+func (c *codefresh) GetPipelines() ([]*Pipeline, error) {
 	r := &getPipelineResponse{}
-	resp := c.requestAPI(&requestOptions{
+	resp, err := c.requestAPI(&requestOptions{
 		path:   "/api/pipelines",
 		method: "GET",
 	})
 	resp.JSON(r)
-	return r.Docs
+	return r.Docs, err
 }
 
-func (c *codefresh) RunPipeline(name string) string {
-	resp := c.requestAPI(&requestOptions{
+func (c *codefresh) RunPipeline(name string) (string, error) {
+	resp, err := c.requestAPI(&requestOptions{
 		path:   fmt.Sprintf("/api/pipelines/run/%s", url.PathEscape(name)),
 		method: "POST",
 	})
-	return resp.String()
+	return resp.String(), err
 }

pkg/codefresh/tokens.go

@@ -7,8 +7,8 @@ import (
 
 type (
 	ITokenAPI interface {
-		GenerateToken(name string, subject string) *Token
-		GetTokens() []*Token
+		GenerateToken(name string, subject string) (*Token, error)
+		GetTokens() ([]*Token, error)
 	}
 
 	Token struct {
@@ -40,8 +40,8 @@ func (s tokenSubjectType) String() string {
 	return [...]string{"runtime-environment"}[s]
 }
 
-func (c *codefresh) GenerateToken(name string, subject string) *Token {
-	resp := c.requestAPI(&requestOptions{
+func (c *codefresh) GenerateToken(name string, subject string) (*Token, error) {
+	resp, err := c.requestAPI(&requestOptions{
 		path:   "/api/auth/key",
 		method: "POST",
 		body: map[string]interface{}{
@@ -55,17 +55,17 @@ func (c *codefresh) GenerateToken(name string, subject string) *Token {
 	return &Token{
 		Name:  name,
 		Value: resp.String(),
-	}
+	}, err
 }
 
-func (c *codefresh) GetTokens() []*Token {
+func (c *codefresh) GetTokens() ([]*Token, error) {
 	emptySlice := make([]*Token, 0)
-	resp := c.requestAPI(&requestOptions{
+	resp, err := c.requestAPI(&requestOptions{
 		path:   "/api/auth/keys",
 		method: "GET",
 	})
 	tokensAsBytes := []byte(resp.String())
 	json.Unmarshal(tokensAsBytes, &emptySlice)
 
-	return emptySlice
+	return emptySlice, err
 }