Skip to content

Commit 3333330

Browse files
CR-3980 bump task logger, fix memory leak (#69)
1 parent 20dd723 commit 3333330

File tree

6 files changed

+21
-20
lines changed

6 files changed

+21
-20
lines changed

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v11.10.0
1+
v10.24.0

lib/logger.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class Logger {
7979

8080
logger.info(`Logging container created for logger id: ${this.loggerId}`);
8181

82-
TaskLogger(this.taskLoggerConfig.task, this.taskLoggerConfig.opts)
82+
TaskLogger(this.taskLoggerConfig.task, { ...this.taskLoggerConfig.opts, updateLogsRate: true })
8383
.then((taskLogger) => {
8484
this.taskLogger = taskLogger;
8585
taskLogger.on('error', (err) => {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"cf-container-logger"
77
],
88
"dependencies": {
9-
"@codefresh-io/task-logger": "^1.8.13",
9+
"@codefresh-io/task-logger": "^1.8.15",
1010
"body-parser": "^1.19.0",
1111
"cf-errors": "^0.1.15",
1212
"cf-logs": "^1.1.0",

service.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version: 1.4.6
1+
version: 1.4.7

test/logger.unit.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ describe('Logger tests', () => {
111111
logger.start();
112112

113113
await Q.delay(10);
114-
expect(TaskLoggerFactory).to.have.been.calledWith(taskLoggerConfig.task, taskLoggerConfig.opts);
114+
expect(TaskLoggerFactory).to.have.been.calledWith(taskLoggerConfig.task, { ...taskLoggerConfig.opts, updateLogsRate: true });
115115
expect(logger._listenForNewContainers).to.have.been.calledOnce; // jshint ignore:line
116116
expect(logger._writeNewState).to.have.been.calledOnce; // jshint ignore:line
117117
expect(logger._listenForExistingContainers).to.not.have.been.called; // jshint ignore:line

yarn.lock

+16-15
Original file line numberDiff line numberDiff line change
@@ -38,23 +38,22 @@
3838
dependencies:
3939
regenerator-runtime "^0.13.4"
4040

41-
"@codefresh-io/task-logger@^1.8.13":
42-
version "1.8.13"
43-
resolved "https://registry.yarnpkg.com/@codefresh-io/task-logger/-/task-logger-1.8.13.tgz#d66795698cd9b3b853376bb1a19048bc54147c01"
44-
integrity sha512-4hxe6qAkM+Q8OlAT4uehJKm5hgzD+Nonu7LUtp7lzcngdlwSnPzjRMnFldHIlY4qaCqQmTr+ZG43PZtCk85qGw==
41+
"@codefresh-io/task-logger@^1.8.15":
42+
version "1.8.15"
43+
resolved "https://registry.yarnpkg.com/@codefresh-io/task-logger/-/task-logger-1.8.15.tgz#a5351f20268b2fcb64f1691d4fe2ead27557dd5c"
44+
integrity sha512-m4RAHGoHuzS3K0vOt09vrGaOhr64CJXxItgQ0T6POnW6zmw7kfR0EV8g6lv65EREYE6hHRgXdIA/Uvvq/KLuAw==
4545
dependencies:
46-
cf-errors "^0.1.15"
47-
crypto "0.0.3"
46+
cf-errors "^0.1.16"
4847
debug "^4.1.1"
4948
firebase "git+https://github.com/codefresh-io/firebase.git#80b2ed883ff281cd67b53bd0f6a0bbd6f330fed5"
5049
firebase-token-generator "^2.0.0"
5150
jsonwebtoken "^8.4.0"
52-
lodash "4.17.20"
51+
lodash "^4.17.21"
5352
mongodb "^3.1.13"
5453
node-redis-pubsub "^4.0.0"
5554
q "^1.4.1"
5655
redis "^2.8.0"
57-
request "2.88.2"
56+
request "^2.88.2"
5857
requestretry "^4.1.2"
5958
retry "^0.12.0"
6059

@@ -758,6 +757,13 @@ cf-errors@^0.1.15:
758757
dependencies:
759758
lodash "4.17.20"
760759

760+
cf-errors@^0.1.16:
761+
version "0.1.16"
762+
resolved "https://registry.yarnpkg.com/cf-errors/-/cf-errors-0.1.16.tgz#03d0b050ac94762552792907b08bd39d1a012116"
763+
integrity sha512-ewA6cTS+bVC32NCxIdEu/5HQ8zb09PV1ubdu0t2yPXs51K31gI78+XGEomVjaXdTbZcGBPVIWhFnG6R/U7K4IQ==
764+
dependencies:
765+
lodash "^4.17.21"
766+
761767
cf-logs@^1.1.0:
762768
version "1.1.22"
763769
resolved "https://registry.yarnpkg.com/cf-logs/-/cf-logs-1.1.22.tgz#cc7e6701cb15565cfc74130fe82e92464aa0cf1c"
@@ -1096,11 +1102,6 @@ cross-spawn@^7.0.2:
10961102
shebang-command "^2.0.0"
10971103
which "^2.0.1"
10981104

1099-
1100-
version "0.0.3"
1101-
resolved "https://registry.yarnpkg.com/crypto/-/crypto-0.0.3.tgz#470a81b86be4c5ee17acc8207a1f5315ae20dbb0"
1102-
integrity sha1-RwqBuGvkxe4XrMggeh9TFa4g27A=
1103-
11041105
11051106
version "1.0.3"
11061107
resolved "https://registry.yarnpkg.com/cycle/-/cycle-1.0.3.tgz#21e80b2be8580f98b468f379430662b046c34ad2"
@@ -3101,7 +3102,7 @@ lodash.once@^4.0.0:
31013102
resolved "https://registry.yarnpkg.com/lodash.once/-/lodash.once-4.1.1.tgz#0dd3971213c7c56df880977d504c88fb471a97ac"
31023103
integrity sha1-DdOXEhPHxW34gJd9UEyI+0cal6w=
31033104

3104-
[email protected], lodash@^4.17.11, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.4:
3105+
[email protected], lodash@^4.17.11, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.17.4:
31053106
version "4.17.20"
31063107
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.20.tgz#b44a9b6297bcb698f1c51a3545a2b3b368d59c52"
31073108
integrity sha512-PlhdFcillOINfeV7Ni6oF1TAEayyZBoZ8bcshTHqOYJYlrqzRK5hagpagky5o4HfCzzd1TRkXPMFq6cKk9rGmA==
@@ -4142,7 +4143,7 @@ request-promise@^4.2.6:
41424143
stealthy-require "^1.1.1"
41434144
tough-cookie "^2.3.3"
41444145

4145-
request@2.88.2, request@^2.88.2:
4146+
request@^2.88.2:
41464147
version "2.88.2"
41474148
resolved "https://registry.yarnpkg.com/request/-/request-2.88.2.tgz#d73c918731cb5a87da047e207234146f664d12b3"
41484149
integrity sha512-MsvtOrfG9ZcrOwAW+Qi+F6HbD0CWXEh9ou77uOb7FM2WPhwT7smM833PzanhJLsgXjN89Ir6V2PczXNnMpwKhw==

0 commit comments

Comments
 (0)