Skip to content

Commit 1cbdebb

Browse files
committed
Move patched_versions conversion to Issue
1 parent a73ecde commit 1cbdebb

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

lib/cc/engine/bundler_audit/issue.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,12 @@ def line_number
5858
end
5959

6060
def remediation_points
61-
Remediation.new(gem.version, advisory.patched_versions).points
61+
patched_versions = advisory.patched_versions.map do |gem_requirement|
62+
requirements = Gem::Requirement.parse(gem_requirement)
63+
requirements.last
64+
end
65+
66+
Remediation.new(gem.version, patched_versions).points
6267
end
6368

6469
def severity

lib/cc/engine/bundler_audit/remediation.rb

+2-5
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,8 @@ def current_version
4040
end
4141

4242
def upgrade_versions
43-
@upgrade_versions ||= patched_versions.map do |gem_requirement|
44-
requirements = Gem::Requirement.parse(gem_requirement)
45-
unqualified_version = requirements.last
46-
47-
Versionomy.parse(unqualified_version.to_s)
43+
@upgrade_versions ||= patched_versions.map do |version|
44+
Versionomy.parse(version.to_s)
4845
end
4946
end
5047
end

0 commit comments

Comments
 (0)