Waiter fixes (#947)

* updated waitUntilExists functionality

* deprecated waitUntilExist, waitForStaleness

Author: DavertMik

docs/pageobjects.md

@@ -231,9 +231,6 @@ At initialization you were asked to create custom steps file. If you accepted th
 See how `login` method can be added to `I`:
 
 ```js
-'use strict';
-// in this file you can append custom step methods to 'I' object
-
 module.exports = function() {
   return actor({
 
@@ -248,4 +245,36 @@ module.exports = function() {
 
 Please notice that instead of `I` you should use `this` in current context.
 
+## Dependency Injection
+
+### Configuration
+
+All objects described here are injected with Dependency Injection. The similar way it happens in AngularJS framework.
+If you want an object to be injected in scenario by its name add it to configuration:
+
+```js
+  "include": {
+    "I": "./custom_steps.js",
+    "Smth": "./pages/Smth.js",
+    "loginPage": "./pages/Login.js",
+    "signinFragment": "./fragments/Signin.js"
+  }
+```
+
+Now this objects can be retrieved by the name specified in configuration.
+CodeceptJS generator commands (like `codeceptjs gpo`) will update configuration for you.
+
+### Dynamic Injection
+
+You can inject objects per test by calling `injectDependencies` function on Scenario:
+
+```js
+Scenario('search @grop', (I, Data) => {
+  I.fillField('Username', Data.username);
+  I.pressKey('Enter');
+}).injectDependencies({ Data: require('./data.js') });
+```
+
+This requires `./data.js` module and assigns it to `Data` argument in a test.
+
 ### done()

docs/webapi/waitForStalenessOf.mustache renamed to docs/webapi/waitForDetached.mustache

@@ -2,7 +2,7 @@ Waits for an element to become not attached to the DOM on a page (by default wai
 Element can be located by CSS or XPath.
 
 ```
-I.waitForStalenessOf('#popup');
+I.waitForDetached('#popup');
 ```
 
 @param locator element located by CSS|XPath|strict locator

docs/webapi/waitUntilExists.mustache

@@ -899,19 +899,30 @@ class Protractor extends Helper {
     return this.browser.wait(EC.presenceOf(el), aSec * 1000);
   }
 
+  async waitUntilExists(locator, sec = null) {
+    console.log(`waitUntilExists deprecated:
+    * use 'waitForElement' to wait for element to be attached
+    * use 'waitForDetached to wait for element to be removed'`);
+    return this.waitForDetached(locator, sec);
+  }
+
   /**
-   * {{> ../webapi/waitUntilExists }}
+   * {{> ../webapi/waitForDetached }}
    */
-  waitUntilExists(locator, sec = null) {
+  async waitForDetached(locator, sec = null) {
     const aSec = sec || this.options.waitForTimeout;
     const el = global.element(guessLocator(locator) || global.by.css(locator));
     return this.browser.wait(EC.not(EC.presenceOf(el)), aSec * 1000);
   }
 
   /**
    * Waits for element to become clickable for number of seconds.
+   *
+   * ```js
+   * I.waitForClickable('#link');
+   * ```
    */
-  waitForClickable(locator, sec = null) {
+  async waitForClickable(locator, sec = null) {
     const aSec = sec || this.options.waitForTimeout;
     const el = global.element(guessLocator(locator) || global.by.css(locator));
     return this.browser.wait(EC.elementToBeClickable(el), aSec * 1000);
@@ -920,7 +931,7 @@ class Protractor extends Helper {
   /**
    * {{> ../webapi/waitForVisible }}
    */
-  waitForVisible(locator, sec = null) {
+  async waitForVisible(locator, sec = null) {
     const aSec = sec || this.options.waitForTimeout;
     const el = global.element(guessLocator(locator) || global.by.css(locator));
     return this.browser.wait(EC.visibilityOf(el), aSec * 1000);
@@ -929,23 +940,23 @@ class Protractor extends Helper {
   /**
    * {{> ../webapi/waitForInvisible }}
    */
-  waitForInvisible(locator, sec = null) {
+  async waitForInvisible(locator, sec = null) {
     const aSec = sec || this.options.waitForTimeout;
     const el = global.element(guessLocator(locator) || global.by.css(locator));
     return this.browser.wait(EC.invisibilityOf(el), aSec * 1000);
   }
 
-  /**
-   * {{> ../webapi/waitForStalenessOf }}
-   */
-  waitForStalenessOf(locator, sec = null) {
+  async waitForStalenessOf(locator, sec = null) {
+    console.log(`waitForStalenessOf deprecated.
+    * Use waitForDetached to wait for element to be removed from page
+    * Use waitForInvisible to wait for element to be hidden on page`);
     return this.waitForInvisible(locator, sec);
   }
 
   /**
    * {{> ../webapi/waitForText }}
    */
-  waitForText(text, sec = null, context = null) {
+  async waitForText(text, sec = null, context = null) {
     if (!context) {
       context = this.context;
     }

lib/helper/Protractor.js

@@ -1419,13 +1419,11 @@ class WebDriverIO extends Helper {
     }, aSec * 1000, `element (${locator}) still not present on page after ${aSec} sec`);
   }
 
-  /**
-   * {{> ../webapi/waitUntilExists }}
-   * Appium: support
-   */
   async waitUntilExists(locator, sec = null) {
-    const aSec = sec || this.options.waitForTimeout;
-    return this.browser.waitForExist(locator, aSec * 1000);
+    console.log(`waitUntilExists deprecated:
+    * use 'waitForElement' to wait for element to be attached
+    * use 'waitForDetached to wait for element to be removed'`);
+    return this.waitForStalenessOf(locator, sec);
   }
 
 
@@ -1594,11 +1592,16 @@ class WebDriverIO extends Helper {
     return this.waitForInvisible(locator, sec);
   }
 
+  async waitForStalenessOf(locator, sec = null) {
+    console.log('waitForStalenessOf deprecated. Use waitForDetached instead');
+    return this.waitForDetached(locator, sec);
+  }
+
   /**
-   * {{> ../webapi/waitForStalenessOf }}
+   * {{> ../webapi/waitForDetached }}
    * Appium: support
    */
-  async waitForStalenessOf(locator, sec = null) {
+  async waitForDetached(locator, sec = null) {
     const aSec = sec || this.options.waitForTimeout;
     return this.browser.waitUntil(async () => {
       const res = await this.browser.elements(withStrictLocator.call(this, locator));