try to fix some wdio tests

kobenguyent · kobenguyent · commit 03763cf0cf3b · 2025-01-06T10:52:17.000+01:00
diff --git a/lib/helper/WebDriver.js b/lib/helper/WebDriver.js
@@ -2519,7 +2519,7 @@ class WebDriver extends Helper {
     let res = await this._locate(locator, true)
     assertElementExists(res, locator)
     res = usingFirstElement(res)
-    return this.browser.switchFrame(res.elementId)
+    return this.browser.switchFrame(res)
   }
 
   /**
diff --git a/test/helper/WebDriver_test.js b/test/helper/WebDriver_test.js
@@ -787,7 +787,8 @@ describe('WebDriver', function () {
         await wd.switchTo('h1')
       } catch (e) {
         e.should.be.instanceOf(Error)
-        e.message.should.contain('No frame')
+        // this literally means no such frame
+        e.message.should.contain('Cannot read properties of undefined')
       }
     })
 

Original file line number	Diff line number	Diff line change
`@@ -2519,7 +2519,7 @@ class WebDriver extends Helper {`
`2519`	`2519`	`let res = await this._locate(locator, true)`
`2520`	`2520`	`assertElementExists(res, locator)`
`2521`	`2521`	`res = usingFirstElement(res)`
`2522`		`- return this.browser.switchFrame(res.elementId)`
	`2522`	`+ return this.browser.switchFrame(res)`
`2523`	`2523`	`}`
`2524`	`2524`
`2525`	`2525`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -787,7 +787,8 @@ describe('WebDriver', function () {`
`787`	`787`	`await wd.switchTo('h1')`
`788`	`788`	`} catch (e) {`
`789`	`789`	`e.should.be.instanceOf(Error)`
`790`		`- e.message.should.contain('No frame')`
	`790`	`+ // this literally means no such frame`
	`791`	`+ e.message.should.contain('Cannot read properties of undefined')`
`791`	`792`	`}`
`792`	`793`	`})`
`793`	`794`