-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Labels
🆘 help wantedassistance is requiredassistance is required🌊 NxNx related issuesNx related issues💡 good first issuegood for newcomersgood for newcomers🔬 testingwriting testswriting tests
Description
Leftover of #777:
- each test in testing/test-nx-utils/src/lib/utils/tree.integration.test.ts should clean up after itself (the strategy is on our Wiki).
- In testing/test-nx-utils/src/lib/utils/nx.unit.test.ts there should be no need for conditional statements in tests. The test should know what is expected and not insert any default values such as {}. I would suggest using ! here.
JSON.parse(tree.read('nx.json')!.toString())
- In testing/test-nx-utils/src/lib/utils/nx.unit.test.ts to get auto-complete if there is a non-trivial type to match, you can use satisfies or a type argument. Applicable in multiple places.
Metadata
Metadata
Assignees
Labels
🆘 help wantedassistance is requiredassistance is required🌊 NxNx related issuesNx related issues💡 good first issuegood for newcomersgood for newcomers🔬 testingwriting testswriting tests