Use message as fallback, not key (microsoft#166323)

TylerLeonhardt · web-flow · commit eab327316292 · 2022-11-14T21:28:31.000-08:00
Because `key` will also contain comments like: ``` my message/i'm a comment the user shouldn't see ``` The other part of microsoft#165735 fixes microsoft#165735
diff --git a/src/vs/workbench/api/common/extHostLocalizationService.ts b/src/vs/workbench/api/common/extHostLocalizationService.ts
@@ -46,7 +46,7 @@ export class ExtHostLocalizationService implements ExtHostLocalizationShape {
 		if (!str) {
 			this.logService.warn(`Using default string since no string found in i18n bundle that has the key: ${key}`);
 		}
-		return format2(str ?? key, (args ?? {}));
+		return format2(str ?? message, (args ?? {}));
 	}
 
 	getBundle(extensionId: string): { [key: string]: string } | undefined {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export class ExtHostLocalizationService implements ExtHostLocalizationShape {`
`46`	`46`	`if (!str) {`
`47`	`47`	this.logService.warn(`Using default string since no string found in i18n bundle that has the key: ${key}`);
`48`	`48`	`}`
`49`		`- return format2(str ?? key, (args ?? {}));`
	`49`	`+ return format2(str ?? message, (args ?? {}));`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`getBundle(extensionId: string): { [key: string]: string } \| undefined {`