Fix diagnostics for implicit activation events not appearing (microsoft#167081)

joyceerhl · web-flow · commit d799b6c18f25 · 2022-11-23T10:33:32.000-08:00
* Fix diagnostics for implicit activation events not appearing

* Fix line endings
diff --git a/extensions/extension-editing/src/extensionLinter.ts b/extensions/extension-editing/src/extensionLinter.ts
@@ -148,7 +148,7 @@ export class ExtensionLinter {
 						}
 					}
 					const activationEventsNode = findNodeAtLocation(tree, ['activationEvents']);
-					if (Array.isArray(activationEventsNode) && activationEventsNode.children) {
+					if (activationEventsNode?.type === 'array' && activationEventsNode.children) {
 						for (const activationEventNode of activationEventsNode.children) {
 							const activationEvent = getNodeValue(activationEventNode);
 							for (const implicitActivationEventPrefix of reservedImplicitActivationEventPrefixes) {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ export class ExtensionLinter {`
`148`	`148`	`}`
`149`	`149`	`}`
`150`	`150`	`const activationEventsNode = findNodeAtLocation(tree, ['activationEvents']);`
`151`		`- if (Array.isArray(activationEventsNode) && activationEventsNode.children) {`
	`151`	`+ if (activationEventsNode?.type === 'array' && activationEventsNode.children) {`
`152`	`152`	`for (const activationEventNode of activationEventsNode.children) {`
`153`	`153`	`const activationEvent = getNodeValue(activationEventNode);`
`154`	`154`	`for (const implicitActivationEventPrefix of reservedImplicitActivationEventPrefixes) {`