Comments view: add badge with the number of unresolved comments (microsoft#164743)

* Comments view: add badge with the number of unresolved comments

Fixes microsoft#164623

* fix formatting

* Remove duplicate listeners
to resolve undercounting

Co-authored-by: Alex Ross <[email protected]>

Author: laurentlb

src/vs/workbench/contrib/comments/browser/commentsView.ts

@@ -36,6 +36,9 @@ import { CommentsFilters, CommentsFiltersChangeEvent } from 'vs/workbench/contri
 import { Memento, MementoObject } from 'vs/workbench/common/memento';
 import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
 import { FilterOptions } from 'vs/workbench/contrib/comments/browser/commentsFilterOptions';
+import { IActivityService, NumberBadge } from 'vs/workbench/services/activity/common/activity';
+import { CommentThreadState } from 'vs/editor/common/languages';
+import { IDisposable, MutableDisposable } from 'vs/base/common/lifecycle';
 
 const CONTEXT_KEY_HAS_COMMENTS = new RawContextKey<boolean>('commentsView.hasComments', false);
 const VIEW_STORAGE_ID = 'commentsViewState';
@@ -47,9 +50,11 @@ export class CommentsPanel extends FilterViewPane implements ICommentsView {
 	private messageBoxContainer!: HTMLElement;
 	private commentsModel!: CommentsModel;
 	private totalComments: number = 0;
+	private totalUnresolved = 0;
 	private readonly hasCommentsContextKey: IContextKey<boolean>;
 	private readonly filter: Filter;
 	readonly filters: CommentsFilters;
+	private readonly activity = this._register(new MutableDisposable<IDisposable>());
 
 	private currentHeight = 0;
 	private currentWidth = 0;
@@ -73,6 +78,7 @@ export class CommentsPanel extends FilterViewPane implements ICommentsView {
 		@ICommentService private readonly commentService: ICommentService,
 		@ITelemetryService telemetryService: ITelemetryService,
 		@IUriIdentityService private readonly uriIdentityService: IUriIdentityService,
+		@IActivityService readonly activityService: IActivityService,
 		@IStorageService readonly storageService: IStorageService
 	) {
 		const stateMemento = new Memento(VIEW_STORAGE_ID, storageService);
@@ -97,15 +103,6 @@ export class CommentsPanel extends FilterViewPane implements ICommentsView {
 		}, this.contextKeyService));
 		this.filter = new Filter(new FilterOptions(this.filterWidget.getFilterText(), this.filters.showResolved, this.filters.showUnresolved));
 
-		this._register(this.commentService.onDidSetAllCommentThreads(e => {
-			this.totalComments += e.commentThreads.length;
-		}));
-
-		this._register(this.commentService.onDidUpdateCommentThreads(e => {
-			this.totalComments += e.added.length;
-			this.totalComments -= e.removed.length;
-		}));
-
 		this._register(this.filters.onDidChange((event: CommentsFiltersChangeEvent) => {
 			if (event.showResolved || event.showUnresolved) {
 				this.updateFilter();
@@ -114,6 +111,16 @@ export class CommentsPanel extends FilterViewPane implements ICommentsView {
 		this._register(this.filterWidget.onDidChangeFilterText(() => this.updateFilter()));
 	}
 
+	private updateBadge(unresolved: number) {
+		if (unresolved === this.totalUnresolved) {
+			return;
+		}
+
+		this.totalUnresolved = unresolved;
+		const message = nls.localize('totalUnresolvedComments', '{0} Unresolved Comments', this.totalUnresolved);
+		this.activity.value = this.activityService.showViewActivity(this.id, { badge: new NumberBadge(this.totalUnresolved, () => message) });
+	}
+
 	override saveState(): void {
 		this.viewState['filter'] = this.filterWidget.getFilterText();
 		this.viewState['filterHistory'] = this.filterWidget.getHistory();
@@ -389,11 +396,36 @@ export class CommentsPanel extends FilterViewPane implements ICommentsView {
 
 	private onAllCommentsChanged(e: IWorkspaceCommentThreadsEvent): void {
 		this.commentsModel.setCommentThreads(e.ownerId, e.commentThreads);
+
+		this.totalComments += e.commentThreads.length;
+
+		let unresolved = 0;
+		for (const thread of e.commentThreads) {
+			if (thread.state === CommentThreadState.Unresolved) {
+				unresolved++;
+			}
+		}
+		this.updateBadge(unresolved);
+
 		this.refresh();
 	}
 
 	private onCommentsUpdated(e: ICommentThreadChangedEvent): void {
 		const didUpdate = this.commentsModel.updateCommentThreads(e);
+
+		this.totalComments += e.added.length;
+		this.totalComments -= e.removed.length;
+
+		let unresolved = 0;
+		for (const resource of this.commentsModel.resourceCommentThreads) {
+			for (const thread of resource.commentThreads) {
+				if (thread.threadState === CommentThreadState.Unresolved) {
+					unresolved++;
+				}
+			}
+		}
+		this.updateBadge(unresolved);
+
 		if (didUpdate) {
 			this.refresh();
 		}