Respect task close options on background tasks

alexr00 · alexr00 · commit 0d0a8f1aac4c · 2021-07-13T11:53:03.000+02:00
Fixes microsoft#128416
diff --git a/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts b/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
@@ -1207,7 +1207,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
 		}
 
 		if ((presentationOptions.close === undefined) || (presentationOptions.close === false)) {
-			if ((presentationOptions.reveal !== RevealKind.Never) || !task.configurationProperties.isBackground) {
+			if ((presentationOptions.reveal !== RevealKind.Never) || !task.configurationProperties.isBackground || (presentationOptions.close === false)) {
 				if (presentationOptions.panel === PanelKind.New) {
 					waitOnExit = nls.localize('closeTerminal', 'Press any key to close the terminal.');
 				} else if (presentationOptions.showReuseMessage) {

Original file line number	Diff line number	Diff line change
`@@ -1207,7 +1207,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {`
`1207`	`1207`	`}`
`1208`	`1208`
`1209`	`1209`	`if ((presentationOptions.close === undefined) \|\| (presentationOptions.close === false)) {`
`1210`		`- if ((presentationOptions.reveal !== RevealKind.Never) \|\| !task.configurationProperties.isBackground) {`
	`1210`	`+ if ((presentationOptions.reveal !== RevealKind.Never) \|\| !task.configurationProperties.isBackground \|\| (presentationOptions.close === false)) {`
`1211`	`1211`	`if (presentationOptions.panel === PanelKind.New) {`
`1212`	`1212`	`waitOnExit = nls.localize('closeTerminal', 'Press any key to close the terminal.');`
`1213`	`1213`	`} else if (presentationOptions.showReuseMessage) {`