storeliveness: remove stale TODO #158909
Merged
storeliveness: remove stale TODO #158909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer applies as the cluster setting is on by default. Epic: none Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
tbg
approved these changes
Dec 8, 2025
Collaborator
Author
|
Thanks! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
158810: build: update PGO profile to 20251204202750-818ff5108cdb1f16f69b3d915acdb4f669b848eb.pb.gz r=srosenberg a=cockroach-teamcity
This PR updates the PGO (Profile-Guided Optimization) profile used for building CockroachDB.
The new profile was validated using tpcc-nowait benchmarks. Results comparing the old profile (before) vs new profile (after):
```
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ops/sec │ ops/sec vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 135.4 ± 3% 136.9 ± 4% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 1.355k ± 3% 1.369k ± 4% ~ (p=0.703 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 135.4 ± 3% 136.9 ± 4% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 1.355k ± 3% 1.369k ± 4% ~ (p=0.703 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 135.4 ± 3% 136.9 ± 4% ~ (p=0.713 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 3.115k ± 3% 3.150k ± 4% ~ (p=0.703 n=20)
geomean 492.1 497.6 +1.10%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/avg │ ms/avg vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 67.55 ± 3% 67.20 ± 6% ~ (p=0.693 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 108.4 ± 3% 106.1 ± 3% ~ (p=0.457 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 14.45 ± 4% 14.40 ± 5% ~ (p=0.416 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 29.70 ± 5% 30.90 ± 5% ~ (p=0.176 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 19.65 ± 1% 19.55 ± 3% ~ (p=0.804 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 64.20 ± 3% 63.50 ± 4% ~ (p=0.693 n=20)
geomean 39.78 39.74 -0.11%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p50 │ ms/p50 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 63.95 ± 5% 62.90 ± 7% ~ (p=0.582 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 104.9 ± 4% 102.8 ± 2% ~ (p=0.611 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 9.400 ± 6% 9.400 ± 6% ~ (p=0.104 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 26.20 ± 4% 27.30 ± 8% ~ (p=0.163 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 15.20 ± 3% 15.45 ± 6% ~ (p=0.734 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 50.30 ± 4% 50.30 ± 4% ~ (p=0.426 n=20)
geomean 32.88 32.99 +0.34%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p95 │ ms/p95 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 113.2 ± 4% 113.2 ± 4% ~ (p=0.622 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 192.9 ± 4% 184.5 ± 9% ~ (p=0.269 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 41.90 ± 5% 41.90 ± 5% ~ (p=0.621 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 60.80 ± 3% 60.80 ± 3% ~ (p=0.960 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 48.20 ± 4% 46.10 ± 5% ~ (p=0.338 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 163.6 ± 3% 159.4 ± 5% ~ (p=0.102 n=20)
geomean 87.17 85.51 -1.90%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p99 │ ms/p99 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 146.8 ± 3% 142.6 ± 6% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 234.9 ± 4% 226.5 ± 7% ~ (p=0.211 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 65.00 ± 3% 62.90 ± 7% ~ (p=0.220 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 88.10 ± 5% 86.00 ± 2% ~ (p=0.957 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 71.30 ± 6% 71.30 ± 0% ~ (p=0.449 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 213.9 ± 2% 209.7 ± 4% ~ (p=0.210 n=20)
geomean 120.2 117.4 -2.34%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/max │ ms/max vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 255.8 ± 5% 285.2 ± 12% ~ (p=0.090 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 402.7 ± 8% 402.7 ± 8% ~ (p=0.700 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 172.0 ± 12% 176.2 ± 10% ~ (p=0.501 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 230.7 ± 5% 222.3 ± 9% ~ (p=0.421 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 192.9 ± 9% 192.9 ± 9% ~ (p=0.781 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 402.7 ± 8% 402.7 ± 8% ~ (p=0.700 n=20)
geomean 261.2 265.4 +1.61%
```
Epic: none
Release note: none
158909: storeliveness: remove stale TODO r=arulajmani a=arulajmani
No longer applies as the cluster setting is on by default.
Epic: none
Release note: None
158936: go.mod: bump Pebble to eec404107db6 r=RaduBerinde a=RaduBerinde
Changes:
* [`eec40410`](cockroachdb/pebble@eec40410) objstorageprovider: add dual-write for cold metadata
* [`fd11d171`](cockroachdb/pebble@fd11d171) objstorageprovider: clean up datadriven tests
* [`fd767661`](cockroachdb/pebble@fd767661) go.mod: update datadriven
* [`cebacb9c`](cockroachdb/pebble@cebacb9c) db: remove FilterType option
* [`26371eaf`](cockroachdb/pebble@26371eaf) internal/base: introduce KVMeta, iterators
Release note: none.
Epic: none.
Co-authored-by: Justin Beaver <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
craig bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
158810: build: update PGO profile to 20251204202750-818ff5108cdb1f16f69b3d915acdb4f669b848eb.pb.gz r=srosenberg a=cockroach-teamcity
This PR updates the PGO (Profile-Guided Optimization) profile used for building CockroachDB.
The new profile was validated using tpcc-nowait benchmarks. Results comparing the old profile (before) vs new profile (after):
```
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ops/sec │ ops/sec vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 135.4 ± 3% 136.9 ± 4% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 1.355k ± 3% 1.369k ± 4% ~ (p=0.703 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 135.4 ± 3% 136.9 ± 4% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 1.355k ± 3% 1.369k ± 4% ~ (p=0.703 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 135.4 ± 3% 136.9 ± 4% ~ (p=0.713 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 3.115k ± 3% 3.150k ± 4% ~ (p=0.703 n=20)
geomean 492.1 497.6 +1.10%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/avg │ ms/avg vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 67.55 ± 3% 67.20 ± 6% ~ (p=0.693 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 108.4 ± 3% 106.1 ± 3% ~ (p=0.457 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 14.45 ± 4% 14.40 ± 5% ~ (p=0.416 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 29.70 ± 5% 30.90 ± 5% ~ (p=0.176 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 19.65 ± 1% 19.55 ± 3% ~ (p=0.804 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 64.20 ± 3% 63.50 ± 4% ~ (p=0.693 n=20)
geomean 39.78 39.74 -0.11%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p50 │ ms/p50 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 63.95 ± 5% 62.90 ± 7% ~ (p=0.582 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 104.9 ± 4% 102.8 ± 2% ~ (p=0.611 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 9.400 ± 6% 9.400 ± 6% ~ (p=0.104 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 26.20 ± 4% 27.30 ± 8% ~ (p=0.163 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 15.20 ± 3% 15.45 ± 6% ~ (p=0.734 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 50.30 ± 4% 50.30 ± 4% ~ (p=0.426 n=20)
geomean 32.88 32.99 +0.34%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p95 │ ms/p95 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 113.2 ± 4% 113.2 ± 4% ~ (p=0.622 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 192.9 ± 4% 184.5 ± 9% ~ (p=0.269 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 41.90 ± 5% 41.90 ± 5% ~ (p=0.621 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 60.80 ± 3% 60.80 ± 3% ~ (p=0.960 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 48.20 ± 4% 46.10 ± 5% ~ (p=0.338 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 163.6 ± 3% 159.4 ± 5% ~ (p=0.102 n=20)
geomean 87.17 85.51 -1.90%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/p99 │ ms/p99 vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 146.8 ± 3% 142.6 ± 6% ~ (p=0.683 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 234.9 ± 4% 226.5 ± 7% ~ (p=0.211 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 65.00 ± 3% 62.90 ± 7% ~ (p=0.220 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 88.10 ± 5% 86.00 ± 2% ~ (p=0.957 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 71.30 ± 6% 71.30 ± 0% ~ (p=0.449 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 213.9 ± 2% 209.7 ± 4% ~ (p=0.210 n=20)
geomean 120.2 117.4 -2.34%
│ artifacts/benchstat_before.txt │ artifacts/benchstat_after.txt │
│ ms/max │ ms/max vs base │
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/delivery 255.8 ± 5% 285.2 ± 12% ~ (p=0.090 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/neworder 402.7 ± 8% 402.7 ± 8% ~ (p=0.700 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/orderstatus 172.0 ± 12% 176.2 ± 10% ~ (p=0.501 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/payment 230.7 ± 5% 222.3 ± 9% ~ (p=0.421 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/stocklevel 192.9 ± 9% 192.9 ± 9% ~ (p=0.781 n=20)
TPCC/tpcc-nowait/literal/w=1000/nodes=5/cpu=16/total 402.7 ± 8% 402.7 ± 8% ~ (p=0.700 n=20)
geomean 261.2 265.4 +1.61%
```
Epic: none
Release note: none
158909: storeliveness: remove stale TODO r=arulajmani a=arulajmani
No longer applies as the cluster setting is on by default.
Epic: none
Release note: None
158936: go.mod: bump Pebble to eec404107db6 r=RaduBerinde a=RaduBerinde
Changes:
* [`eec40410`](cockroachdb/pebble@eec40410) objstorageprovider: add dual-write for cold metadata
* [`fd11d171`](cockroachdb/pebble@fd11d171) objstorageprovider: clean up datadriven tests
* [`fd767661`](cockroachdb/pebble@fd767661) go.mod: update datadriven
* [`cebacb9c`](cockroachdb/pebble@cebacb9c) db: remove FilterType option
* [`26371eaf`](cockroachdb/pebble@26371eaf) internal/base: introduce KVMeta, iterators
Release note: none.
Epic: none.
158986: ts: limit the recording of child metrics to a small set of metrics r=jasonlmfong a=jasonlmfong
This change adds an explicit list of metrics which we perform child metrics collection for.
This helps bound the performance impact even when the cluster setting `timeseries.child_metrics.enable`d is turned on.
Epic: CRDB-55079
Release: The list of metrics which we record child metrics in TSDB has been reduced from all changefeed metrics to a defined list.
Co-authored-by: Justin Beaver <[email protected]>
Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Jason Fong <[email protected]>
Contributor
|
Build failed (retrying...):
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer applies as the cluster setting is on by default.
Epic: none
Release note: None