Skip to content

Commit 9a63b5c

Browse files
committed
made sure INTEGTEST_DBGYM_CFG isn't created more than once
1 parent 4ae2d85 commit 9a63b5c

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

env/integtest_util.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,14 @@ def set_up_workspace() -> None:
2222
if not IntegtestWorkspace.get_workspace_path().exists():
2323
subprocess.run(["./env/set_up_env_integtests.sh"], check=True)
2424

25-
# The DBGymConfig needs to be created after running ./env/set_up_env_integtests.sh so
26-
# that it is created correctly.
27-
IntegtestWorkspace.INTEGTEST_DBGYM_CFG = DBGymConfig(
28-
IntegtestWorkspace.ENV_INTEGTESTS_DBGYM_CONFIG_FPATH
29-
)
25+
# Once we get here, we have an invariant that the workspace exists. We need this
26+
# invariant to be true in order to create the DBGymConfig.
27+
#
28+
# However, it also can't be created more than once so we need to check `is None`.
29+
if IntegtestWorkspace.INTEGTEST_DBGYM_CFG is None:
30+
IntegtestWorkspace.INTEGTEST_DBGYM_CFG = DBGymConfig(
31+
IntegtestWorkspace.ENV_INTEGTESTS_DBGYM_CONFIG_FPATH
32+
)
3033

3134
@staticmethod
3235
def get_dbgym_cfg() -> DBGymConfig:

0 commit comments

Comments
 (0)