Skip to content

Commit 569ee2a

Browse files
authored
fix tests (#36)
* fix tests * rebuild pipeline * set TF_VAR_ * delete bad fixture setting * use GITHUB_TOKEN for testing
1 parent 22c2e90 commit 569ee2a

File tree

6 files changed

+6
-14
lines changed

6 files changed

+6
-14
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343
[![Cloud Posse][logo]](https://cpco.io/homepage)
4444

45-
# terraform-aws-ecs-codepipeline [![Codefresh Build Status](https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-ecs-codepipeline?type=cf-1)](https://g.codefresh.io/public/accounts/cloudposse/pipelines/5db7b474041f802a8893f018) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
45+
# terraform-aws-ecs-codepipeline [![GitHub Action Tests](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/workflows/test/badge.svg?branch=master)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/actions) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
4646

4747

4848
Terraform Module for CI/CD with AWS Code Pipeline using GitHub webhook triggers and Code Build for ECS.

README.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ github_repo: cloudposse/terraform-aws-ecs-codepipeline
1818

1919
# Badges to display
2020
badges:
21-
- name: "Codefresh Build Status"
22-
image: "https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-ecs-codepipeline?type=cf-1"
23-
url: "https://g.codefresh.io/public/accounts/cloudposse/pipelines/5db7b474041f802a8893f018"
21+
- name: "GitHub Action Tests"
22+
image: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/workflows/test/badge.svg?branch=master"
23+
url: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/actions"
2424
- name: "Latest Release"
2525
image: "https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg"
2626
url: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest"

examples/complete/fixtures.us-east-2.tfvars

-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ container_port_mappings = [
8080

8181
github_oauth_token = "test"
8282

83-
github_webhooks_token = "test"
84-
8583
repo_owner = "cloudposse"
8684

8785
repo_name = "terraform-aws-ecs-codepipeline"

examples/complete/main.tf

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module "vpc" {
2424
}
2525

2626
module "subnets" {
27-
source = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.16.1"
27+
source = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.19.0"
2828
availability_zones = var.availability_zones
2929
namespace = var.namespace
3030
stage = var.stage
@@ -91,7 +91,6 @@ module "ecs_codepipeline" {
9191
name = var.name
9292
region = var.region
9393
github_oauth_token = var.github_oauth_token
94-
github_webhooks_token = var.github_webhooks_token
9594
repo_owner = var.repo_owner
9695
repo_name = var.repo_name
9796
branch = var.branch

examples/complete/variables.tf

-5
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,6 @@ variable "github_oauth_token" {
159159
description = "GitHub OAuth Token with permissions to access private repositories"
160160
}
161161

162-
variable "github_webhooks_token" {
163-
type = string
164-
description = "GitHub OAuth Token with permissions to create webhooks. If not provided, can be sourced from the `GITHUB_TOKEN` environment variable"
165-
}
166-
167162
variable "repo_owner" {
168163
type = string
169164
description = "GitHub Organization or Username"

main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ resource "aws_codepipeline_webhook" "webhook" {
309309
}
310310

311311
module "github_webhooks" {
312-
source = "git::https://github.com/cloudposse/terraform-github-repository-webhooks.git?ref=tags/0.5.0"
312+
source = "git::https://github.com/cloudposse/terraform-github-repository-webhooks.git?ref=tags/0.7.0"
313313
enabled = var.enabled && var.webhook_enabled ? true : false
314314
github_organization = var.repo_owner
315315
github_repositories = [var.repo_name]

0 commit comments

Comments
 (0)